EZEE-2533: Error HTTP 400 trying to preview Form during creation #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawbuj
reviewed
Mar 11, 2019
|
What about user root location or some other custom ones? |
|
This is not needed in context of this bug, but maybe it is worth to add other custom root locations. What do you think about it? |
webhdx
suggested changes
Mar 11, 2019
mikadamczyk
force-pushed
the
EZEE-2533
branch
2 times, most recently
from
c852345 to
28ce778
Compare
mikadamczyk
force-pushed
the
EZEE-2533
branch
2 times, most recently
from
c69e332 to
9c45ada
Compare
webhdx
suggested changes
Mar 12, 2019
adamwojs
approved these changes
Mar 12, 2019
ViniTou
approved these changes
Mar 12, 2019
| continue; | ||
| $context = new SiteaccessPreviewVoterContext($location, $versionInfo, $siteaccess, $languageCode); | ||
| foreach ($this->siteaccessPreviewVoters as $siteaccessPreviewVoter) { | ||
| if (true === $siteaccessPreviewVoter->vote($context)) { |
barbaragr
approved these changes
Mar 19, 2019
|
merged up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ezsystems/ezplatform-form-builder/pull/143
Checklist:
$ composer fix-cs)