EZP-30269: [Content Tree] Collapse all button jumps a little bit when scrolling #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
approved these changes
Mar 8, 2019
micszo
reviewed
Mar 8, 2019
|
While working on something you must provide support for all supported browsers. It is waste of time time fixing it for Chrome only and traveling back in time to fix it in Firefox, Edge, etc. |
|
This does not solved problem in 100% in Firefox but it is significant improvement and only minor flickering is sometimes visible (at least on my computer). |
|
On Firefox when tree is collapsed it's not so bad but when it's expanded it's not only flickering but also jumping.
|
|
OK, so on my Firefox it looks way better:
I guess it is connected with performance of the machine and browser capabilities. We may leave this PR for now and think about better solution. Or maybe merge this as code improvement but not as PR fixing bug? |
tischsoic
force-pushed
the
EZP-20269-Collapse-all-button-jumps-a-little-bit-when-scrolling
branch
from
706b057 to
7158f0a
Compare
lserwatka
deleted the
EZP-20269-Collapse-all-button-jumps-a-little-bit-when-scrolling
branch
mateuszdebinski
pushed a commit
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was inspired by: https://css-tricks.com/styling-based-on-scroll-position/
Previously we were afraid of poor performance because of frequent updates of DOM element and use of
getBoundingClientRect. Current solution should be performant.Before
After
Checklist:
$ composer fix-cs)