EZP-30224: Make ez_user_settings twig global load user settings dynamically
#876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webhdx
requested review from
lserwatka,
adamwojs,
mikadamczyk,
Nattfarinn,
pawbuj and
ViniTou
mikadamczyk
approved these changes
Mar 5, 2019
pawbuj
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
ez_user_settingsglobal to provide dynamic access to User Setting values. Previously it was required to manually put all needed user settings in theUserPreferencesGlobalExtensionbut it was prone to errors as can be seen in 45058c2Checklist:
$ composer fix-cs)