Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30139: As an editor I want to hide and reveal a content item #865

Merged
merged 8 commits into from
Mar 4, 2019
Merged

EZP-30139: As an editor I want to hide and reveal a content item #865

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
738f24c
EZP-30139: As an editor I want to hide and reveal a content item
pawbuj Feb 28, 2019
50db204
cs fixes and refactoring
pawbuj Mar 4, 2019
c01e3e1
fixes js cs
pawbuj Mar 4, 2019
906c285
cs fixes
pawbuj Mar 4, 2019
bed8310
more cs fixes
pawbuj Mar 4, 2019
b45daa5
cs fixes
pawbuj Mar 4, 2019
2b4f837
fix
pawbuj Mar 4, 2019
c157e28
fixes
pawbuj Mar 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixes js cs
  • Loading branch information
@pawbuj
pawbuj committed Mar 4, 2019
commit c01e3e1ca47760e27bf6373347a94eb4d3cd29c7
6 changes: 0 additions & 6 deletions src/bundle/Resources/public/scss/_icons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,12 +215,6 @@
}
}

.ez-alert--icon {
width: calculateRem(16px);
height: calculateRem(16px);
margin-right: calculateRem(4px);
}

.ez-alert--info {
fill: currentColor;
vertical-align: middle;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those styles should not be part of icons.scss. This is part of alerts.scss.

Expand Down
4 changes: 2 additions & 2 deletions src/bundle/Resources/views/content/locationview.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@
{% include '@ezdesign/parts/breadcrumbs.html.twig' with { items: items } %}

{% if location.contentInfo.isHidden %}
<div class="ez-alert--info">
<svg class="ez-icon ez-alert--icon">
<div class="ez-alert ez-alert--info">
<svg class="ez-icon ez-icon--small">
<use xlink:href="/bundles/ezplatformadminui/img/ez-icons.svg#hide"></use>
</svg>
{{ 'content.hidden.message'|trans()|desc('This content item is hidden and is not publicly available') }}
Expand Down