EZP-30032: CustomTags not saved correctly #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszbieniek
requested review from
sunpietro,
tischsoic,
kmadejski,
dew326,
konradoboza and
andrerom
dew326
requested changes
Feb 7, 2019
src/bundle/Resources/public/js/alloyeditor/src/buttons/ez-btn-customtag-update.js
Outdated
Show resolved
Hide resolved
sunpietro
approved these changes
Feb 7, 2019
konradoboza
approved these changes
Feb 7, 2019
kmadejski
approved these changes
Feb 7, 2019
dew326
reviewed
Feb 8, 2019
| @@ -210,6 +210,8 @@ | |||
| */ | |||
| setName: function(name) { | |||
| this.element.data('ezname', name); | |||
| window.clearTimeout(this.setNameFireEditorInteractionTimeout); | |||
There was a problem hiding this comment.
Each timeout handler should be defined at the top (after the editables object).
setNameFireEditorInteractionTimeout: null| @@ -263,6 +265,8 @@ | |||
| setAlignment: function(type) { | |||
| this.wrapper.data(DATA_ALIGNMENT_ATTR, type); | |||
| this.element.data(DATA_ALIGNMENT_ATTR, type); | |||
| window.clearTimeout(this.setAlignmentFireEditorInteractionTimeout); | |||
| this.setAlignmentFireEditorInteractionTimeout = window.setTimeout(this.fireEditorInteraction.bind(this,'aligmentUpdated'), 50); | |||
There was a problem hiding this comment.
Missing space after , in bind(this,'aligmentUpdated'), applies in other cases.
| @@ -274,6 +278,8 @@ | |||
| unsetAlignment: function() { | |||
| this.wrapper.data(DATA_ALIGNMENT_ATTR, false); | |||
| this.element.data(DATA_ALIGNMENT_ATTR, false); | |||
| window.clearTimeout(this.unsetAlignmentFireEditorInteractionTimeout); | |||
| this.unsetAlignmentFireEditorInteractionTimeout = window.setTimeout(this.fireEditorInteraction.bind(this,'aligmentRemoved'), 50); | |||
There was a problem hiding this comment.
Those lines seem to be too long. Do you use Prettier?
There was a problem hiding this comment.
Nope, I will in the future, thanks!
mateuszbieniek
force-pushed
the
EZP-30032
branch
from
d366606 to
c35b8ac
Compare
dew326
approved these changes
Feb 8, 2019
tischsoic
approved these changes
Feb 8, 2019
barbaragr
approved these changes
Feb 12, 2019
|
Could you merge it up? |
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a line to fire
editorInteractionevent at the end of CustomTag creation in RichText so AlloyEditor's UI is updated and aware of the changes.As a side effect this PR fixes also this issue: https://jira.ez.no/browse/EZP-30010