Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29990: As an Administrator I want to translate ezselection Field Definition options #824

Merged

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Jan 31, 2019

Question Answer
Tickets https://jira.ez.no/browse/EZP-29990
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? yes
License GPL-2.0

Kernel:
ezsystems/ezpublish-kernel#2532
Repository-forms:
ezsystems/repository-forms#277

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

{% endfor %}
</ul>
{% elseif not fieldSettings.isMultiple %}
{% set attr = attr|merge({'class': (attr.class|default('') ~ ' ez-field-preview ez-field-preview--ezselection-single')|trim}) %}
{% set field_value = fieldSettings.options[field.value.selection.0] %}
{% set field_value = options[field.value.selection.0] %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: field.value.selection|first

@ViniTou ViniTou force-pushed the EZP-29990-translate-ezselection-options branch from 07df591 to 36d86df Compare February 25, 2019 09:18
@lserwatka lserwatka merged commit 80096c6 into ezsystems:master Feb 25, 2019
konradoboza pushed a commit to konradoboza/ezplatform-admin-ui that referenced this pull request May 29, 2019
…Definition options (ezsystems#824)

* EZP-29990: As an Administrator I want to translate ezselection Field Definition options

* EZP-29990: As an Administrator I want to translate ezselection Field Definition options

* EZP-29990: Enable buttons when translated

* EZP-29990: reverse field change name

* EZP-29990: Use contentTypeDraftMapper as dependency
mateuszdebinski pushed a commit that referenced this pull request Feb 13, 2024
[Behat] Added timeout for select content releation single

Co-authored-by: Bogdan Mazur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants