Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30094: User is unable to change object state #823

Merged
merged 1 commit into from
Feb 1, 2019
Merged

EZP-30094: User is unable to change object state #823

merged 1 commit into from
Feb 1, 2019

Conversation

adamwojs
Copy link
Member

Question Answer
Tickets EZP-30094
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@adamwojs adamwojs added the Bug label Jan 31, 2019
@adamwojs adamwojs self-assigned this Jan 31, 2019
webhdx
webhdx suggested changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@webhdx webhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think removing $name argument from FormFactory::updateContentObjectState is the answer. I understand intention to move from using our FormFactory to Symfony's FormFactory but I wouldn't force it unless it doesn't introduce BC breaking changes.

@webhdx webhdx requested a review from Nattfarinn January 31, 2019 13:37
@barbaragr barbaragr self-assigned this Feb 1, 2019
@lserwatka lserwatka merged commit e57c218 into ezsystems:master Feb 1, 2019
@adamwojs adamwojs deleted the ezp_30094 branch February 1, 2019 11:32
mateuszdebinski pushed a commit that referenced this pull request Feb 13, 2024
@bogusez
[Behat] IBX-5755 Added test scenarios for product variants (#823)
a8249c5 
Co-authored-by: Bogdan Mazur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbaragr barbaragr barbaragr approved these changes

@webhdx webhdx webhdx approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@lserwatka lserwatka Awaiting requested review from lserwatka

@pawbuj pawbuj Awaiting requested review from pawbuj

@ViniTou ViniTou Awaiting requested review from ViniTou

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

Assignees

@adamwojs adamwojs

@barbaragr barbaragr

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamwojs @mikadamczyk @webhdx @barbaragr @lserwatka