EZP-30024: Simplifies object states table #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawbuj
requested review from
adamwojs,
mikadamczyk,
sunpietro,
Nattfarinn,
alongosz,
webhdx,
tischsoic,
dew326,
micszo and
ViniTou
|
Can you add some screenshots? |
|
done |
tischsoic
approved these changes
Jan 30, 2019
dew326
requested changes
Jan 30, 2019
| <source>Identifier</source> | ||
| <target state="new">Identifier</target> | ||
| <note>key: tab.details.state_identifier</note> | ||
| </trans-unit> | ||
| <trans-unit id="69dea878e2926e6a40b3d4e79b1f723d0aa801c7" resname="tab.details.state_name"> | ||
| <source>Name</source> |
There was a problem hiding this comment.
Shouldn't this be the same like target?
| <note>key: tab.details.state_name</note> | ||
| </trans-unit> | ||
| <trans-unit id="5c08278a7b80c4aae97e5683688b5b55b5f5b37e" resname="tab.details.change_state"> | ||
| <source>Name</source> |
webhdx
reviewed
Jan 30, 2019
| @@ -70,7 +70,7 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
| return array_filter( | |||
| $this->objectStateService->loadObjectStates($objectStateGroup), | |||
| function (ObjectState $objectState) use ($contentInfo, $contentState) { | |||
| return $this->permissionResolver->canUser('state', 'assign', $contentInfo, [$objectState]) && $contentState->id !== $objectState->id; | |||
There was a problem hiding this comment.
@pawbuj I'm wondering why you had to remove && $contentState->id !== $objectState->id?
There was a problem hiding this comment.
there is an additional requirement ordered by @SylvainGuittard to display a list of all states
There was a problem hiding this comment.
That is the main goal of this PR.
Users were confused to not see all the object states in the dropdown list. So we display all the states that the user has the rights to change
dew326
approved these changes
Jan 30, 2019
pawbuj
force-pushed
the
EZP-30024_simplify_states_table
branch
from
b72cbd3 to
e9fc3a2
Compare
webhdx
approved these changes
Jan 31, 2019
mikadamczyk
approved these changes
Jan 31, 2019
alongosz
approved these changes
Jan 31, 2019
adamwojs
approved these changes
Jan 31, 2019
sunpietro
approved these changes
Jan 31, 2019
barbaragr
approved these changes
Jan 31, 2019
konradoboza
pushed a commit
to konradoboza/ezplatform-admin-ui
that referenced
this pull request
May 29, 2019
* EZP-30024: Simplifies object states table * fixes translations * changes color of the set button
mateuszdebinski
pushed a commit
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies object states table
Checklist:
$ composer fix-cs)