Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30064: As an editor I would like to view a content tree in location view #814

Merged
merged 2 commits into from
Jan 30, 2019

Conversation

sunpietro
Copy link
Contributor

Question Answer
Tickets https://jira.ez.no/browse/EZP-30064
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes/no
Doc needed? yes/no
License GPL-2.0

zrzut ekranu 2019-01-29 o 16 37 17

FOR QA AND REVIEWERS:

The feature will be implemented incrementally. That means, that the design will be changing in the forthcoming pull requests. In this PR I focused on preparing the content tree module base and implementing the basic file structure.

Requires: ezsystems/ezplatform-admin-ui-modules#136

@sunpietro sunpietro force-pushed the ezp-30064-content-tree branch from 42c25f9 to d271716 Compare January 30, 2019 08:58
@sunpietro
Copy link
Contributor Author

ping pong @dew326 @tischsoic

@@ -0,0 +1,14 @@
.ez-content-view {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files should be named _content-view.scss. Here the pattern is with -.

@@ -170,6 +174,7 @@
'@EzPlatformAdminUiBundle/Resources/public/js/scripts/button.state.toggle.js'
'@EzPlatformAdminUiBundle/Resources/public/js/scripts/admin.version.edit.conflict.js'
'@EzPlatformAdminUiBundle/Resources/public/js/scripts/admin.location.bookmark.js'
'@EzPlatformAdminUiModulesBundle/Resources/public/js/ContentTree.module.js'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it working? The JS which needs this file is added before. This should be moved to the react_modules block.

@sunpietro
Copy link
Contributor Author

ping @dew326

@lserwatka lserwatka merged commit fbb5df0 into master Jan 30, 2019
@lserwatka lserwatka deleted the ezp-30064-content-tree branch January 30, 2019 14:56
konradoboza pushed a commit to konradoboza/ezplatform-admin-ui that referenced this pull request May 29, 2019
…on view (ezsystems#814)

* EZP-30064: As an editor I would like to view a content tree in location view

* fixup
mateuszdebinski pushed a commit that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants