Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-28773: [v2] Issues with page scrolling during actions in rich text editor #801

Merged
merged 2 commits into from
Jan 23, 2019
Merged

EZP-28773: [v2] Issues with page scrolling during actions in rich text editor #801

merged 2 commits into from
Jan 23, 2019

Conversation

konradoboza
Copy link
Member

@konradoboza konradoboza commented Jan 16, 2019 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZP-28773
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This PR contains fixes ported from v1 for all reported issues regarding scrolling when inserting objects/links into the RichText.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@konradoboza konradoboza self-assigned this Jan 16, 2019
@konradoboza konradoboza force-pushed the EZP-28773-scrolling_richtext branch from ed6a802 to 5012691 Compare January 16, 2019 13:54
@konradoboza
Copy link
Member Author

@dew326 fixed.

@konradoboza konradoboza removed their assignment Jan 16, 2019
@konradoboza konradoboza requested a review from micszo January 18, 2019 15:25
@konradoboza
Copy link
Member Author

Travis fail is unrelated, ping @micszo

@micszo
Copy link
Member

micszo commented Jan 21, 2019

Indeed because fix for tests was only done from 1.3 (f86558e).

@katarzynazawada katarzynazawada self-assigned this Jan 22, 2019
@lserwatka
Copy link
Member

@m-tyrala behat is failing here. Is it related?

@m-tyrala
Copy link
Contributor

@lserwatka looking into it, there is an error in PHP Unit tests not in Behat tests

  1. EzSystems\EzPlatformAdminUi\Tests\Form\DataTransformer\LocationsTransformerTest::testReverseTrans
    formWithIds
    Failed asserting that two arrays are equal.
    --- Expected
    +++ Actual
    @@ @@
    Array (
  • 0 => eZ\Publish\Core\Repository\Values\Content\Location Object (...)
  • 1 => eZ\Publish\Core\Repository\Values\Content\Location Object (...)
  • 0 => null
  • 1 => null
    /home/travis/build/ezsystems/ezplatform-admin-ui/src/lib/Tests/Form/DataTransformer/LocationsTransformerTest.php:48

@konradoboza
Copy link
Member Author

As I mentioned earlier, it doesn't seem related.

@lserwatka lserwatka merged commit c7856fc into ezsystems:1.2 Jan 23, 2019
@lserwatka
Copy link
Member

You can merge it up

mateuszdebinski pushed a commit that referenced this pull request Feb 13, 2024
@webhdx
Merge branch '2.3' of ezsystems/ezplatform-admin-ui into 4.4 (#801)
5dccdf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@mateuszbieniek mateuszbieniek mateuszbieniek approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@sunpietro sunpietro Awaiting requested review from sunpietro

@micszo micszo Awaiting requested review from micszo

Assignees

@katarzynazawada katarzynazawada

Labels
Bug Ready for MERGE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@konradoboza @micszo @lserwatka @m-tyrala @tischsoic @dew326 @mateuszbieniek @katarzynazawada