EZP-29833 : Limiting "Content\Create" to Section disables "Publish" button

[pawbuj]

Question	Answer
Tickets	EZP-29833
Bug fix?	yes
New feature?	no
BC breaks?	no
Tests pass?	yes
Doc needed?	no
License	GPL-2.0

Fixes permission check for content creation when rights are limited some section.

Checklist:

• Coding standards ($ composer fix-cs)
• Ready for Code Review

[ezrobot]

Tool version : PHP CS Fixer 2.7.1 Sandy Pool by Fabien Potencier and Dariusz Ruminski
Command executed php-cs-fixer --dry-run -v fix
This Pull Request does not respect PSR-2 Coding Standards, please, see the suggested diff below:

diff --git a/src/lib/Menu/ContentCreateRightSidebarBuilder.php b/src/lib/Menu/ContentCreateRightSidebarBuilder.php
index c3338b8..ba847fe 100644
--- a/src/lib/Menu/ContentCreateRightSidebarBuilder.php
+++ b/src/lib/Menu/ContentCreateRightSidebarBuilder.php
@@ -107,7 +107,6 @@ class ContentCreateRightSidebarBuilder extends AbstractBuilder implements Transl
         $canCreate = $this->permissionResolver->canUser('content', 'create', $contentCreateStruct, [$locationCreateStruct]) && $parentContentType->isContainer;
         $canPreview = $this->permissionResolver->canUser('content', 'versionread', $contentCreateStruct, [$locationCreateStruct]);
 
-
         $publishAttributes = [
             'class' => self::BTN_TRIGGER_CLASS,
             'data-click' => '#ezrepoforms_content_edit_publish',

[ViniTou]

return class could be also typehinted

[pawbuj]

done

[ViniTou]

Also, not sure how all of you are feeling about creating those structs inside menuBuilder instead of passing them as options.
@webhdx
@Nattfarinn
@adamwojs

[mikadamczyk]

I doubt that it is worth to add a private method, which we can not reuse, rather than add one line. The similar situation is at least in two places.

[pawbuj]

The main reason to add createContentCreateStruct function was to increase readability of the code.

[micszo]

@pawbuj according to Affects Version/s base needs to be changed to 1.3. Also please rebase afterwards.

[micszo]

What about Content on the Fly? This place isn't covered by this fix. Could we fix that as well?

[pawbuj]

@pawbuj according to Affects Version/s base needs to be changed to 1.3. Also please rebase afterwards.

done

[pawbuj]

@micszo yes, sure we should also fix this, but I think that we should have a new task for this in jira.

[lserwatka]

@pawbuj we don’t create tickets per affected version. You simply set right target branch (1.3 in your case) and after merge we merge it up to master.

[pawbuj]

I mean a new ticket for the button in the modal (screenshot by @micszo ). Target branch is already changed to 1.3.

[micszo]

@pawbuj there you go https://jira.ez.no/browse/EZP-30001.

[micszo]

👍

[lserwatka]

You can merge it up