Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29714: Fix failing to detect disabled next button #742

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Dec 10, 2018

Question Answer
Tickets http://jira.ez.no/browse/EZP-29714
Bug fix? yes (in tests)
New feature? no
BC breaks? no
Tests pass? should
Doc needed? yes/no

Current ezplatform-ee-demo master branch build is failing, it hangs on Changes can be discarded while creating Content Type test, on And there's no "Test Content Type" on "Content" "Content Type Group" list. This is caused by incorrectly detecting that the Next button is disabled, sending the tests into an infinite loop 😓 This change fixes the issue.

Build for this PR: https://github.com/ezsystems/ezplatform-page-builder/pull/271 should be green (it has this PR added as a dependency: https://github.com/mnocon/ezplatform-ee-demo/commit/d03c88b23c5f8dfb3e19c0d4980c8237e03ca3f6)

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mnocon mnocon requested review from m-tyrala and removed request for m-tyrala December 10, 2018 14:41
@mnocon mnocon changed the title [WIP] EZP-29714: Fix failing to detect disabled next button EZP-29714: Fix failing to detect disabled next button Dec 11, 2018
@mnocon mnocon requested a review from m-tyrala December 11, 2018 07:29
Copy link
Contributor

@m-tyrala m-tyrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@mnocon
Copy link
Member Author

mnocon commented Dec 11, 2018

@lserwatka this one can be merged

@lserwatka lserwatka merged commit 33c5d8a into master Dec 11, 2018
@lserwatka lserwatka deleted the EZP-29714-fix-pagination-tests branch December 11, 2018 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants