EZP-29115: Add characters counter to RichText #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
requested review from
lserwatka,
adamwojs,
andrerom,
SylvainGuittard and
inakijv
konradoboza
force-pushed
the
EZP-29115-characters_counter
branch
from
59273f8 to
fbe42d0
Compare
konradoboza
force-pushed
the
EZP-29115-characters_counter
branch
from
440fa04 to
beb0da3
Compare
konradoboza
force-pushed
the
EZP-29115-characters_counter
branch
from
beb0da3 to
10c4110
Compare
# Conflicts: # src/bundle/Resources/config/services/user_settings.yml
konradoboza
force-pushed
the
EZP-29115-characters_counter
branch
from
b24b93f to
64544f8
Compare
konradoboza
force-pushed
the
EZP-29115-characters_counter
branch
2 times, most recently
from
bd29b96 to
c24476c
Compare
konradoboza
force-pushed
the
EZP-29115-characters_counter
branch
from
c24476c to
72ebea0
Compare
konradoboza
force-pushed
the
EZP-29115-characters_counter
branch
from
74b7bde to
4b869c8
Compare
konradoboza
changed the title
konradoboza
requested review from
dew326 and
tischsoic
and removed request for
SylvainGuittard
|
User settings part was extracted to Implementation was moved from the plugin to |
dew326
requested changes
Mar 1, 2019
src/bundle/Resources/public/js/scripts/fieldType/base/base-rich-text.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/fieldType/base/base-rich-text.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/fieldType/base/base-rich-text.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/fieldType/base/base-rich-text.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/fieldType/base/base-rich-text.js
Outdated
Show resolved
Hide resolved
konradoboza
force-pushed
the
EZP-29115-characters_counter
branch
from
8122a46 to
2faa4a6
Compare
konradoboza
force-pushed
the
EZP-29115-characters_counter
branch
from
2faa4a6 to
d1c4b20
Compare
konradoboza
changed the title
|
@dew326 remarks applied, please take a look. |
dew326
reviewed
Mar 4, 2019
src/bundle/Resources/public/js/scripts/fieldType/base/base-rich-text.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/fieldType/base/base-rich-text.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/fieldType/base/base-rich-text.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/scss/_alloyeditor-character-counter.scss
Outdated
Show resolved
Hide resolved
|
ping @adamwojs @dew326 @tischsoic |
adamwojs
reviewed
Mar 4, 2019
| @@ -61,6 +61,36 @@ | |||
| <target state="new">Sub-items</target> | |||
| <note>key: settings.subitems_limit.value.title</note> | |||
| </trans-unit> | |||
| <trans-unit id="98400a7e546231a994f6fea03dce3ebd52c1c33d" resname="settings.character_counter.value.description"> | |||
There was a problem hiding this comment.
Note to my self: This file should be moved to ezplatform-user.
adamwojs
approved these changes
Mar 4, 2019
dew326
approved these changes
Mar 4, 2019
konradoboza
added a commit
to konradoboza/ezplatform-admin-ui
that referenced
this pull request
May 29, 2019
* EZP-29115: Add characters counter to RichText * removed implementation from plugin, moved user settings part to a separate PR * fixes after CR * fixes after review vol.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a proof of concept for one of the features which was requested by the customer. This is a simple characters counter which is enabled/disabled globally for RichText via User Preferences. The idea is to count all characters inside tags except:
The matter of styling and configuration could be changed, it is rather a basic idea which in my opinion seems to be consistent with the rest of the back office. However all feedback will be warmly welcomed. :) Below I attached some screenshot which presents current state of the feature:
User settings were moved to
ezplatform-userrepository, so it is dependant on: ezsystems/ezplatform-user#8Checklist:
$ composer fix-cs)