EZP-29848: Make existing AdminUI tabs extendable by allowing template path and parameters change #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webhdx
requested review from
lserwatka,
adamwojs,
mikadamczyk,
Nattfarinn,
micszo and
ViniTou
webhdx
changed the title
webhdx
commented
Nov 30, 2018
| 'attr': { 'class': 'ez-toggle-btn-state', 'data-toggle-button-id': '#delete-translations-' ~ form_version_remove_archived.remove.vars.id } | ||
| }) }} | ||
| {% include '@ezdesign/parts/table_header.html.twig' with { headerText: 'tab.versions.archived_versions'|trans()|desc('Archived versions'), tools: tab.table_header_tools(form_version_remove_archived) } %} | ||
| {% block table_wrapper_archived %} | ||
| {% if archived_versions is not empty %} |
There was a problem hiding this comment.
Review note - this if statement is always true because it has been already checked a few lines above thus else block is never reached.
webhdx
commented
Nov 30, 2018
| {% if published_versions is not empty %} | ||
| {{ include('@ezdesign/content/tab/versions/table.html.twig', { 'versions': published_versions }) }} | ||
| {% else %} |
There was a problem hiding this comment.
Review note: Same as below.
webhdx
force-pushed
the
EZP-29848_extendable_tabs
branch
from
18f2ce8 to
7628ef0
Compare
mikadamczyk
approved these changes
Dec 4, 2018
| /** | ||
| * @param string $tabIdentifier | ||
| */ | ||
| public function setTabIdentifier(string $tabIdentifier): void |
There was a problem hiding this comment.
Should we change a tab identifier after creation?
There was a problem hiding this comment.
Good catch, no we should not.
| /** | ||
| * Is dispatched on tabs extending EventDispatchingAbstractTab. | ||
| * | ||
| * Allows to manipulate template path and parameters before rendering by Twig. |
There was a problem hiding this comment.
If we allow changing the identifier than the comment should be changed.
webhdx
force-pushed
the
EZP-29848_extendable_tabs
branch
from
7628ef0 to
fb52fa5
Compare
|
Note for QA: we only need sanities here. cc @micszo |
ViniTou
approved these changes
Dec 7, 2018
micszo
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventDispatchingAbstractTabwhich dispatchesTabEvents::ON_RENDERevent before rendering tab. This gives a flexibility of changing template and accessing parameters to modify them.TODO
EventDispatchingAbstractTabin other tabs after validating idea on code review