-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-29328: As an editor I want AE to support formatted text #709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Did you figure out what caused the toolbar position to go all over the place @dew326 ?
@andrerom yes, it's because the empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor change.
src/bundle/Resources/public/js/alloyeditor/src/toolbars/config/base.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Formatted style is not always passible to choose
- Click on Rich Text Editor
- Change style to Formatted.
- Type same text.
- Change style to Heading 1.
There is no way to change the style to formatted – there is no Formatted block in the list. When changing style to Paragraph Formatted block appears.
- For more text, scroll appears in edit mode. If clicking Add button in situation when cursor is outside the current view, page and toolbar skips.
- RichText Editor is not styled properly when changing styles
A) Safari
- Click on Rich Text Editor
- Change style to Formatted.
- Type same text.
- Add new block (Paragraph).
- Change Paragraph style to Formatted.
- Change the style back to Paragraph.
B) Chrome
Steps like on Safari and then:
- Click outside the editor.
- Go back to Rich Text Editor.
After removing block and clicking in Editor:
Safari:
- Toolbar skips:
- Click on Rich Text Editor
- Change style to Formatted.
- Pre use scroll is not added. (on Edge also)
@katarzynazawada The second issue is not related to our code base. I can reproduce the issue on AlloyEditor demo. I created an issue for AE devs: liferay/alloy-editor#902 |
@dew326 you can merge it up |
Screenshot:
This is a new feature but the target branch is 1.3 as this is needed for the migration.
Checklist:
$ composer fix-cs
)