Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZEE-2306: Add new Page Builder tests #703

Merged
merged 1 commit into from
Nov 26, 2018
Merged

EZEE-2306: Add new Page Builder tests #703

merged 1 commit into from
Nov 26, 2018

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Oct 26, 2018 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZEE-2306
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This PR is required by https://github.com/ezsystems/ezplatform-page-builder/pull/254/files

What has been done:

  • extract JS-based drag and drop so that it can be used outside of PageBuilderEditor (it was needed in Collection and Content Scheduler blocks).
  • make debugging easier by adding more details to ElementNotFoundException
  • add parent container to DateTimePicker - it's required for Pages with more than 1 DatePicker (Content Scheduler airtime)
  • add Content Type Preview skeleton - it's an object created for representing Pages rendered on the frontend (and in Page Builder).

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mnocon mnocon force-pushed the ezee-2306-add-more-pb-tests branch 2 times, most recently from 89c6dbe to 86f6f9b Compare October 29, 2018 20:27
@mnocon mnocon force-pushed the ezee-2306-add-more-pb-tests branch 3 times, most recently from ad9957c to 1d5675f Compare November 8, 2018 09:30
@ezsystems ezsystems deleted a comment from ezrobot Nov 9, 2018
@ezsystems ezsystems deleted a comment from ezrobot Nov 9, 2018
@ezsystems ezsystems deleted a comment from ezrobot Nov 9, 2018
@ezsystems ezsystems deleted a comment from ezrobot Nov 9, 2018
@ezsystems ezsystems deleted a comment from ezrobot Nov 9, 2018
@ezsystems ezsystems deleted a comment from ezrobot Nov 9, 2018
@ezsystems ezsystems deleted a comment from ezrobot Nov 9, 2018
@ezsystems ezsystems deleted a comment from ezrobot Nov 9, 2018
@ezsystems ezsystems deleted a comment from ezrobot Nov 9, 2018
@ezsystems ezsystems deleted a comment from ezrobot Nov 9, 2018
@ezsystems ezsystems deleted a comment from ezrobot Nov 9, 2018
@mnocon mnocon force-pushed the ezee-2306-add-more-pb-tests branch 2 times, most recently from 728b89c to be655d6 Compare November 12, 2018 10:21
@mnocon mnocon changed the title [WIP] Add new Page Builder tests EZEE-2306: Add new Page Builder tests Nov 13, 2018
@mnocon mnocon requested a review from m-tyrala November 21, 2018 08:49
m-tyrala
m-tyrala suggested changes Nov 22, 2018
View reviewed changes
Copy link
Contributor

@m-tyrala m-tyrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally everything is fine, only one small issue. :)

src/lib/Behat/BusinessContext/NotificationContext.php Outdated
$expectedMessage = sprintf("Location '%s' moved to trash.", $locationName);
$this->specificNotificationAppears($expectedMessage);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just use the step @Then success notification that :message appears? Judging from the message format, readability would not suffer from that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change that, sure

@mnocon mnocon force-pushed the ezee-2306-add-more-pb-tests branch from 84d5fc7 to e14c62e Compare November 22, 2018 13:19
@mnocon
Copy link
Member Author

mnocon commented Nov 26, 2018

@lserwatka this one can be merged

@lserwatka lserwatka merged commit ccd8ef9 into 1.3 Nov 26, 2018
@lserwatka lserwatka deleted the ezee-2306-add-more-pb-tests branch November 26, 2018 09:18
ViniTou pushed a commit that referenced this pull request May 12, 2023
@alongosz
Merged branch '2.3' of ezsystems/ezplatform-admin-ui into 4.3 (#703)
58b070d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-tyrala m-tyrala m-tyrala approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnocon @m-tyrala @lserwatka