EZP-29355: As a developer, I want to edit the ezcontent of a custom tag #697
Conversation
dew326
force-pushed
the
editable-ezcontent
branch
2 times, most recently
from
39a14e6 to
25629ef
Compare
| const data = alloyEditor.get('nativeEditor').getData(); | ||
| const doc = document.createDocumentFragment(); | ||
| const root = document.createElement('div'); | ||
| const ezNamespace = 'http://ez.no/namespaces/ezpublish5/xhtml5/edit'; | ||
| const xhtmlNamespace = 'http://www.w3.org/1999/xhtml'; | ||
| const emptyEmbed = function (embedNode) { | ||
| const emptyEmbed = function(embedNode) { |
There was a problem hiding this comment.
Shouldn't it be extracted outside of callback scope, should it?
| embedNode.classList.remove(cl); | ||
| prevRemoveClass(); | ||
| }; | ||
| } | ||
| }); | ||
| removeClass(); | ||
| }; | ||
| const xhtmlify = function (data) { | ||
| const clearCustomTag = (customTag) => { |
There was a problem hiding this comment.
Shouldn't it be extracted outside of callback scope, should it?
| attributesNodes.forEach((attributesNode) => attributesNode.remove()); | ||
| headers.forEach((header) => header.remove()); | ||
| }; | ||
| const xhtmlify = function(data) { |
There was a problem hiding this comment.
Shouldn't it be extracted outside of callback scope, should it?
dew326
force-pushed
the
editable-ezcontent
branch
from
25629ef to
921954d
Compare
|
I think we should reformat all *.js files according to our Prettify rules. Reading further PRs without formatting changes would be a lot easier. :) ping @sunpietro @dew326 |
dew326
force-pushed
the
editable-ezcontent
branch
from
921954d to
5f01495
Compare
|
What is the status of this PR ? I can't really tell based on the latest contributions to it. |
|
@bdunogier This waits for QA, but we cannot test it without "nested custom tags". |
|
Why does testing require nested custom tags, @dew326 ? If you test editing of regular text, without tags in the Also, what is the status of nested custom tags, and/or jira story ? |
|
@micszo tried to test it but we couldn't determinate which problems are because of the ezcontent and which because of nested custom tags. For example, embed and embed image doesn't work because problems in nesting WIthout nested custom tags it's not possible to make full and proper QA, and probably the QA would need to be duplicated while testing nested custom tags. |
|
I understand. On the other hand, we have customers waiting for this, in order to edit content that doesn't include nested tags. I really see benefits in having this feature without the nesting part. The scope would then be very limited, but it would still bring something valuable. Would it be complicated to disable all the OE buttons when the ezcontent editing box has focus ? |
|
But the nested custom tags are planned for 2.4, the same as this I don't see a point in spending time on limiting this and later enable all buttons as it's all planned for 2.4 and will not be released earlier. |
|
I knew you would say that, and it of course makes sense. As long as we don't end up skipping it in 2.4 for some reason, it will have to do. Thank you. |
|
I think we are safe in this case, @alongosz already has the nested custom tags in the current sprint. |
|
Okay, that sounds good. Thank you for the infos, @dew326. |
dew326
force-pushed
the
editable-ezcontent
branch
from
5f01495 to
c860432
Compare
dew326
force-pushed
the
editable-ezcontent
branch
from
c860432 to
e04b411
Compare
Merge branch '2.3' of ezsystems/ezplatform-admin-ui into 4.3
Checklist:
$ composer fix-cs)