EZP-29223: Implement permissions for "Content/Translate" #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikadamczyk
requested review from
adamwojs,
Nattfarinn,
alongosz,
webhdx and
ViniTou
mikadamczyk
force-pushed
the
EZP-29223
branch
from
e85bf38 to
93d6928
Compare
ViniTou
reviewed
Oct 19, 2018
| * | ||
| * @return string[] | ||
| */ | ||
| private function getLanguagesLimitations($limitations): array |
There was a problem hiding this comment.
nitpick $limiations could be also typehinted
| * | ||
| * @return string[] | ||
| */ | ||
| private function getLimitationLanguageCodes($limitations): array |
There was a problem hiding this comment.
Does anyone have a nice idea where we could extract both this method?
There was a problem hiding this comment.
PermissionUtil class that @mikadamczyk is adding in #696 ?
mikadamczyk
force-pushed
the
EZP-29223
branch
2 times, most recently
from
f7a6a48 to
689c6ae
Compare
mikadamczyk
force-pushed
the
EZP-29223
branch
2 times, most recently
from
7ec746f to
0170f8b
Compare
mikadamczyk
force-pushed
the
EZP-29223
branch
2 times, most recently
from
d7627b0 to
a6693e4
Compare
mikadamczyk
force-pushed
the
EZP-29223
branch
from
a6693e4 to
76c2665
Compare
adamwojs
approved these changes
Oct 29, 2018
4 tasks
ViniTou
approved these changes
Oct 30, 2018
|
@barbaragr my bad, I merged it too early be accident. If you find something please still report it here. |
Merged
2 tasks
ViniTou
pushed a commit
that referenced
this pull request
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on ezsystems/ezpublish-kernel#2465
Checklist:
$ composer fix-cs)