EZP-29652 - Multilingual support for ezbinaryfile download in admin UI #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, in the admin, if you display the main view of a content in another language than the default one, it will display the correct link (with the filename in the correct language) but if you click on the download button, you will always get the content of the file in the language of the admin. I hope that this fix could be convenient, I tried it on two of my projects and it fixed the wrong behaviour with no side effect so far. I am using native eZ elements (the prioritizedFieldLanguageCode of the content and the preconfigured inLanguage option for the route).
webhdx
approved these changes
Sep 25, 2018
lserwatka
approved these changes
Sep 25, 2018
|
@amauryvallier thank you for your contribution. Glad to hear you battle tested it as well 👍 It will be part of 2.3 release. |
ViniTou
pushed a commit
that referenced
this pull request
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, in the admin, if you display the main view of a content in another language than the default one, it will display the correct link (with the filename in the correct language) but if you click on the download button, you will always get the content of the file in the language of the admin.
I hope that this fix could be convenient, I tried it on two of my projects and it fixed the wrong behaviour with no side effect so far and basic tests running fine. I used native eZ elements (the prioritizedFieldLanguageCode of the content and the preconfigured inLanguage option for the route).
Checklist:
$ composer fix-cs)