EZP-29635: Styled labels in Admin Panel Edit views #632
Conversation
| .ez-card { | ||
| .form-group, | ||
| .ez-card--fieldtype-container { | ||
| .ez-label { |
There was a problem hiding this comment.
What do you think about making it a generic class. I mean not nested inside another classes.
Just something like this:
.ez-label {
margin-bottom: 0;
font-weight: 700;
&:after {
content: ': ';
}
}They same rule I would apply for the .required class.
There was a problem hiding this comment.
It would be great (I considered that option too). It will simplify more the process.
inakijv
changed the title
|
Updated based on review. Still facing issues here: |
|
@inakijv what are these issues you mentioned? |
|
@sunpietro two views still need styling (I need suggestions/help on how to get them):
|
| @@ -60,6 +60,28 @@ | |||
| } | |||
| } | |||
|
|
|||
| .ez-label { | |||
There was a problem hiding this comment.
If this is a separate component it should be in different file _label.scss.
|
Updated based on review. |
| } | ||
| } | ||
|
|
||
| .ez-label.checkbox-inline, |
There was a problem hiding this comment.
It should go inside the .ez-label { declaration like this: &.checkbox-inline
| } | ||
|
|
||
| .ez-label.checkbox-inline, | ||
| .ez-label.form-check-label { |
There was a problem hiding this comment.
It should go inside the .ez-label { declaration like this: &.form-check-label
| } | ||
| } | ||
|
|
||
| .ez-label.form-check-label:not(.checkbox-inline) { |
There was a problem hiding this comment.
If you follow my suggestions above, then it should be placed inside the &.form-check-label { selector, like this: &:not(.checkbox-inline)
|
Updated based on review. |
|
Updated based on review.
|
Most important aspects:
ez-label, as well as adding a specific class for the view,ez-admin-edit;-> Content type specific Edit view for field type
ezdatetime: Year, Month, Day, Minute, Second;-> Roles specific Edit view
limitationgroup.Would need help _>
-> Content type specific Edit view for field type
ezdatetime: Year, Month, Day, Minute, Second;-> Roles specific Edit view
limitationgroup.Checklist:
$ composer fix-cs)