Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-29636: Additional Update button visible on User Setting update screen #628

Merged
merged 1 commit into from
Sep 18, 2018
Merged

EZP-29636: Additional Update button visible on User Setting update screen #628

merged 1 commit into from
Sep 18, 2018

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Sep 18, 2018 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZP-29636
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

image

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@webhdx webhdx added the Bug label Sep 18, 2018
@webhdx webhdx self-assigned this Sep 18, 2018
@micszo micszo self-assigned this Sep 18, 2018
ViniTou
ViniTou reviewed Sep 18, 2018
View reviewed changes
Copy link
Contributor

@ViniTou ViniTou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be done in symfony form builder? (if possible of course and if it not needed somewhere else)

@micszo micszo removed their assignment Sep 18, 2018
@lserwatka lserwatka merged commit 99352f7 into master Sep 18, 2018
@lserwatka lserwatka deleted the EZP-29636_hide_user_settings_update_button branch September 18, 2018 10:43
ViniTou pushed a commit that referenced this pull request May 12, 2023
@lucasOsti
IBX-4120: fixed margin and padding for UDW list view (#628)
e9bd522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@micszo micszo micszo approved these changes

@ViniTou ViniTou ViniTou approved these changes

@alongosz alongosz Awaiting requested review from alongosz

Assignees

@webhdx webhdx

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@webhdx @adamwojs @mikadamczyk @micszo @ViniTou @lserwatka