EZP-29279: Fix value displayed by the Date Field Type being affected by browser time zone #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by browser time zone
dew326
approved these changes
Aug 17, 2018
4 tasks
andrerom
approved these changes
Aug 21, 2018
webhdx
approved these changes
Sep 3, 2018
|
@lserwatka All other PR's on this bug fix has been merged, so I think this should too. |
|
@tischsoic is this still valid, given you worked on dates recently? |
|
@lserwatka I checked it and problem still does occur. |
|
@micszo could we have a round of QA here so we can include this fix? |
micszo
approved these changes
Mar 14, 2019
|
Retested on v2.2.3 with diff. |
|
@tischsoic could you help merge this up to 1.3/1.4 and master? |
|
@lserwatka PR merged up: |
mateuszdebinski
pushed a commit
that referenced
this pull request
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the value for Date Field Type displayed in the backoffice (in edit mode) is affected by the browser's timezone, meaning that if the browser has timezone below (west of) UTC, then the previous day is displayed.
Value stored in the database is always midnight in UTC.
Javascript automatically uses the browser's timezone when handling Date objects, so in this PR I fix the issue by manually adding the offset before passing the Date object to flatpickr library.
Similar to ezsystems/PlatformUIBundle#984.
Checklist:
$ composer fix-cs)