EZP-29104: Implemented UI for ImageAsset Field Type #580

adamwojs · 2018-07-26T20:38:19Z

Question	Answer
Tickets	https://jira.ez.no/browse/EZP-29104
Depends on	ezsystems/repository-forms#246, ezsystems/ezpublish-kernel#2403
Bug fix?	no
New feature?	yes
BC breaks?	no
Tests pass?	no
Doc needed?	no
License	GPL-2.0

Checklist:

Coding standards ($ composer fix-cs)
Extract translations
Ready for Code Review

dew326 · 2018-07-27T13:38:41Z

src/bundle/Resources/config/universal_discovery_widget.yml

@@ -37,3 +37,6 @@ system:
                    multiple: false
                    content_on_the_fly:
                        allowed_content_types: ['image']
+                image_asset:
+                    multiple: false
+                    visible_tabs: ['browse', 'search', 'bookmarks']


Why you should not be able to create content while picking from UDW?

Good question. I going to check this with PM team 😉

dew326 · 2018-07-27T13:39:16Z

src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js

+    const SELECTOR_INPUT_FILE = 'input[type="file"]';
+    const SELECTOR_LABEL_WRAPPER = '.ez-field-edit__label-wrapper';
+    const SELECTOR_INPUT_DESTINATION_CONTENT_ID = '.ez-field-edit__destination_content_id';
+


No need to separate const

Empty lines are not needed in const

dew326 · 2018-07-27T13:39:52Z

src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js

+    const imageAssetMapping = eZ.adminUiConfig.imageAssetMapping;
+
+    class EzImageAssetPreviewField extends eZ.BasePreviewField {
+


Please remove empty line

dew326 · 2018-07-27T13:41:05Z

src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js

+         * @param {String} languageCode
+         */
+        createImage(file, languageCode) {
+            const assetCreateUri = '/asset/image';


Should be generate by the JS routing

dew326 · 2018-07-27T13:42:59Z

src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js

+            };
+
+            this.toggleLoading(true);
+            fetch(assetCreateUri, options).then((response) => {


Please move this function to some method

dew326 · 2018-07-27T13:47:24Z

src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js

+                canSelectContent,
+                title,
+                multiple: false,
+                startingLocationId: parseInt(imageAssetMapping['parent_location_id'], 10),


This can't be moved to the config?

dew326 · 2018-07-27T13:49:24Z

src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js

+            super.init();
+
+            this.btnSelect = this.fieldContainer.querySelector('.ez-data-source__btn-select');
+            this.btnSelect.addEventListener('click', (event) => {


I do not see a point of this middle function which will only preventDefault, you can do it in openUDW

dew326 · 2018-07-27T13:51:06Z

src/bundle/Resources/public/scss/fieldType/edit/_ezimageasset.scss

+  }
+
+  .ez-field-edit__spinner {
+


this can be remove

dew326 · 2018-07-27T13:51:17Z

src/bundle/Resources/public/scss/fieldType/edit/_ezimageasset.scss

@@ -0,0 +1,78 @@
+.ez-field-edit--ezimageasset {
+  .ez-field-edit-preview {
+    padding: 1.25rem 0 1.25rem 1.25rem;


Indentation 4 spaces

dew326 · 2018-07-27T13:52:33Z

src/bundle/Resources/public/scss/fieldType/edit/_ezimageasset.scss

+  }
+}
+
+.ez-field-edit {


This will override styles for all fields. Cannot be done like this.

adamwojs · 2018-07-31T11:43:54Z

PR rebased and updated according to @dew326 suggestions.

dew326 · 2018-07-31T11:47:23Z

src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js

+    const SELECTOR_INPUT_FILE = 'input[type="file"]';
+    const SELECTOR_LABEL_WRAPPER = '.ez-field-edit__label-wrapper';
+    const SELECTOR_INPUT_DESTINATION_CONTENT_ID = '.ez-field-edit__destination_content_id';
+


Empty lines are not needed in const

dew326 · 2018-07-31T11:48:35Z

src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js

+    const SELECTOR_FIELD = '.ez-field-edit--ezimageasset';
+    const SELECTOR_INPUT_FILE = 'input[type="file"]';
+    const SELECTOR_LABEL_WRAPPER = '.ez-field-edit__label-wrapper';
+    const SELECTOR_INPUT_DESTINATION_CONTENT_ID = '.ez-field-edit__destination_content_id';


not correct BEM class: ez-field-edit__destination-content-id

dew326 · 2018-07-31T11:50:08Z

src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js

+                method: 'POST',
+                headers: {
+                    'Accept': 'application/json',
+                    //'X-CSRF-Token': token


I think the CSRF token should be sent in POST requests .

dew326 · 2018-07-31T11:51:23Z

src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js

+                },
+                body: form,
+                mode: 'same-origin',
+                credentials: 'same-origin'


Do you have Prettier installed? I think we have rule for trailingComma

dew326 · 2018-07-31T11:51:56Z

src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js

+            };
+
+            this.toggleLoading(true);
+            fetch(assetCreateUri, options)


I would add empty line before this fetch

dew326 · 2018-07-31T12:09:32Z

src/bundle/Resources/public/scss/fieldType/edit/_ezimageasset.scss

+    }
+}
+
+.ez-field-edit--ezimageasset {


This can be combined with the rules above

dew326 · 2018-07-31T12:12:58Z

src/bundle/Resources/public/scss/fieldType/edit/_ezimageasset.scss

+}
+
+.ez-field-edit--ezimageasset {
+    &__preview-wrapper {


I think this will be compiled to: ez-field-edit--ezimageasset__preview-wrapper and this is not correct usage of BEM

dew326 · 2018-07-31T12:16:03Z

src/bundle/Resources/public/scss/fieldType/preview/_ezimageasset.scss

+.ez-field-preview--ezimageasset {
+    display: flex;
+
+    .ez-imageasset__wrapper {


Seems like not correct BEM

dew326 · 2018-07-31T12:20:16Z

src/bundle/Resources/views/fieldtypes/edit/ezimageasset.html.twig

+{% endblock %}
+
+{% block ezplatform_fieldtype_ezimageasset_widget %}
+    <div class="ez-data-source__message--main">


Seems like not correct BEM usage

dew326 · 2018-07-31T12:21:26Z

src/bundle/Resources/views/fieldtypes/edit/ezimageasset.html.twig

+    </div>
+
+    {% if max_file_size is defined and max_file_size > 0 %}
+        <div class="ez-data-source__message--filesize">


The same, not correct BEM

webhdx · 2018-07-31T12:20:13Z

src/bundle/Controller/AssetController.php

+
+        $form = $this->formFactory->assetUpload($data, 'form');
+        $form->handleRequest($request);
+        if ($form->isValid()) {


I believe it's advised by Symfony to use $form->isSubmitted() && $form->isValid() together.

webhdx · 2018-07-31T12:23:02Z

src/bundle/Controller/AssetController.php

+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+
+class AssetController extends Controller


I doubt it's a good idea to keep the Controller in AdminUI - what if we need this fieldtype to be available for frontend editing?

webhdx · 2018-07-31T12:24:14Z

src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js

+                method: 'POST',
+                headers: {
+                    'Accept': 'application/json',
+                    //'X-CSRF-Token': token


Commented out code should not be commited.

webhdx · 2018-07-31T12:24:30Z

src/bundle/Resources/views/admin/content_type/field_types.html.twig

@@ -223,3 +223,6 @@
        {{- form_row(form.textRows) -}}
    </div>
 {% endblock %}
+
+{% block ezimageasset_field_definition_edit %}


Is an empty block needed?

webhdx · 2018-07-31T12:28:19Z

src/bundle/Resources/views/fieldtypes/edit/ezimageasset.html.twig

+
+    {% set widget_container_block = block('ezplatform_fieldtype_ezimageasset_widget_container') %}
+
+    {{ block('form_row_fieldtype') }}


You are duplicating a lot of variables from block binary_base_row (defined in binary_base.html.twig). Can't you override only some of the variables (it might require to do some changes to binary_base_row to make it possible) and display binary_base_row?

webhdx · 2018-07-31T12:29:12Z

src/bundle/Resources/views/fieldtypes/preview/ezimageasset.html.twig

+        </tr>
+        <tr>
+            <td>{{ 'ezimageasset.size'|trans|desc('Size') }}:</td>
+            <td>{{ field.value.fileSize|ez_file_size( 1 ) }}</td>


Spaces no needed: ez_file_size(1)

webhdx · 2018-07-31T12:31:02Z

src/bundle/Controller/AssetController.php

+    {
+        $data = new AssetUploadData();
+
+        $form = $this->formFactory->assetUpload($data, 'form');


Name form feels too generic to me.

webhdx · 2018-07-31T12:44:02Z

src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js

+            const assetCreateUri = global.Routing.generate('ezplatform.asset.upload');
+            const form = new FormData();
+
+            form.append('form[languageCode]', languageCode);


You shouldn't manually compose Data object here. Please use existing form:

const request = new Request(form.action, { method: 'POST', body: new FormData(form), mode: 'same-origin', credentials: 'same-origin', });

dew326 · 2018-08-01T06:09:07Z

I have been thinking about the whole idea of using a form in this case and this makes no sense.
As far as I can see you are creating a form, rendering only a few fields and send two fields in POST request. The endpoint gets the form and returning JSON response (so there is no possibility to submit this form in a regular way). Thus we do not need this form at all.

This should be done like this:

no form
a regular POST endpoint which takes in the body:

{
    languageCode: languageCode,
    file: file
}

JS sending POST with the body and CSRF token

webhdx · 2018-08-01T06:37:52Z

Totally overlooked how it's really done yesterday, sorry. I second what @dew326 said. Using Form is convenient, especially when validation and creating data object is needed but in your case it's totally misused. It works but it will be confusing for anyone who maintains the code in the future.

mikadamczyk · 2018-08-01T06:46:27Z

src/bundle/Controller/AssetController.php

+        }
+
+        return new JsonResponse([
+            'status' => 'error',


Is this status field really needed?

mikadamczyk · 2018-08-01T06:54:29Z

src/lib/Form/Data/Asset/AssetUploadData.php

+        $this->languageCode = $languageCode;
+    }
+
+    public function getFile(): ?UploadedFile


missing docblock here and below

adamwojs · 2018-08-02T06:19:03Z

Ready for the second round of code review @dew326, @webhdx, @mikadamczyk.

dew326 · 2018-08-02T06:53:48Z

src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js

+(function(global, doc, eZ, React, ReactDOM, Translator) {
+    const SELECTOR_FIELD = '.ez-field-edit--ezimageasset';
+    const SELECTOR_INPUT_FILE = 'input[type="file"]';
+    const SELECTOR_INPUT_DESTINATION_CONTENT_ID = '.ez-data-source--ezimageasset__destination-content-id';


This in not correct. You shouldn't add children to class with modifier.
ez-data-source__destination-content-id

dew326 · 2018-08-02T07:02:23Z

src/bundle/Resources/views/fieldtypes/preview/ezimageasset.html.twig

+{% set imageAlias = ez_image_alias( field, versionInfo, parameters.alias|default( 'original' ) ) %}
+{% set src = imageAlias ? asset( imageAlias.uri ) : "//:0" %}
+
+<div class="ez-imageasset__wrapper">


ez-field-preview__image-wrapper

adamwojs · 2018-08-03T08:54:38Z

PR ready for the final code review @webhdx @dew326 @mikadamczyk

dew326 · 2018-08-03T09:06:23Z

src/bundle/Resources/views/fieldtypes/edit/ezimageasset.html.twig

+        </div>
+    {% endif %}
+
+    {{- form_widget(form.file, {'attr': attr}) -}}


I think we drop the idea of creating a form for this?

mikadamczyk · 2018-08-06T09:46:46Z

src/bundle/Resources/config/views.yml

+                default:
+                    controller: 'EzPlatformAdminUiBundle:ContentView:locationView'
+                    template: '@ezdesign\fieldtypes\preview\ezimageasset.html.twig'
+                    match: true


missing empty line

webhdx · 2018-08-07T07:50:31Z

src/bundle/Resources/views/fieldtypes/edit/binary_base.html.twig

@@ -20,7 +22,10 @@
        {% set widget_wrapper_attr = widget_wrapper_attr|merge({'hidden': 'hidden'}) %}
    {% endif %}

-    {% set widget_container_block = block('binary_base_widget_container') %}
+    {% if not widget_container_block_name is defined %}


Why not {% if widget_container_block_name is not defined %}? Looks better and reads better.

barbaragr · 2018-08-23T11:27:10Z

I Error 500 after deleting Image used in ImageAssets field

Create Content Type with ImageAsset FieldType
Go to Content/Content structure and create new Content Item based on Content Type from step 1
Upload an image and publish
Go to Media/Images and send to Trash image from previous step
Go back to Content/Content structure and go to view mode of recently published CI
Actual result: error 500: Type error: Argument 1 passed to eZ\Publish\Core\SignalSlot\BookmarkService::isBookmarked() must be an instance of eZ\Publish\API\Repository\Values\Content\Location, null given, called in /var/www/ezplatformee/vendor/ezsystems/ezplatform-admin-ui/src/bundle/Controller/ContentViewController.php on line 366

II Error 500 after editing added image in Media/Image

Create Content Type with ImageAsset FieldType
Go to Content/Content structure and create new Content Item based on Content Type from step 1
Upload an image and publish
Go to Media/Images and find the image and click Edit button to go to edit mode
Remove the image from field Image (Trash button) and publish
Go back to Content/Content structure and go to view mode of recently published CI
Actual result: Error 500: An exception has been thrown during the rendering of a template ("Argument 'BinaryFile::id' is invalid: 'NULL' is wrong value in class 'BinaryFile'").

III Question:
When I'm creating a CI with ImageAssets and I have uploaded an image, but next I remove it using TRash button, should it stay in images repository? Specifications says only about uploading the image and saving a draft. In my situation I saved nothing, so maybe it shouldn't be publish in Media/Images yet?

IV Question:
For scenario:
When I create a new Article
And decide to select an existing image for the Photo field
And try to select any content item which is not an Image content type
Then I can not select the content item
Now I can select, but I can't confirm. Maybe It could be disabled like some CIs are disabled in UDW when user want to swap locations (containers vs non containers). But I'm just asking :)

V User receive error when tries to upload a file which is not an image

Create Content Type with ImageAsset FieldType
Go to Content/Content structure and create new Content Item based on Content Type from step 1
Try to upload, using drag and drop, for example txt file
Actual result: Error while creating image asset is displayed. For ezimage when user drags and drops forbidden file, nothing happens.

barbaragr

VI Permissions:
Preconditions: created CT with ImageAssets field type

Create user Editor
Change Editor's assignments: left only Subtree of Location: /Home
Log in as an Editor
Go to Content/Content structure and click Create
Choose CT with Image Assets field type
Drag and drop an image
Actual result: We receive a message Error while creating image asset - we could be more specific and display sth about permissions, because error occurs if user does't have permissions to create a CI anywhere except Home.

SylvainGuittard · 2018-09-05T05:27:07Z

Thanks @barbaragr for testing.

I Error 500 after deleting Image used in ImageAssets field
I updated the specifications. Please check it again.

II Error 500 after editing added image in Media/Image
This field is not mandatory in the Image content type. So the best solution is to not display the image but the name of the content item. We keep the Open in a new tab link for the user to edit it again.

III Question:
The image should be deleted

IV Question:

Maybe It could be disabled like some CIs are disabled in UDW when user want to swap locations (containers vs non containers).

Totally agree.

adamwojs · 2018-09-05T08:16:34Z

@barbaragr , @SylvainGuittard

This problem is already solved by EZP-29342: Deleting related object for ezobjectrelations field throws error 500 #581. Please confirm it by cherry picking 501190d8ec6d88bffb37ed6455ebee89e78a3975.
I already handled this case by displaying Image asset is not available message but definitely it might be improved. I see what it can do 😉

This is edge case but worth to mention. As the image content item is created and published immediately after upload, this gives a time frame to reuse it in other content. if "Trash" button in content editor will delete related content item so it need same confirmation modal window as impl. as part of EZP-29408: As an editor I want to delete a content item with an image asset field #591 and it need to be permission aware.

PS. I will update PR today 😉

ViniTou · 2018-09-05T08:33:50Z

I can confirm that 1 is solved just by rebasing.

adamwojs · 2018-09-06T06:35:14Z

PR updated according to @barbaragr suggestions and ready to second round of QA.

I decided to handle this issue as @SylvainGuittard suggested. Now when image is empty, the content name will be displayed:

When the related content item is deleted or current user doesn't have permission to see it the the following message will be display:

From technical POV, I implemented Parameter Provider (similar as in case of ezrelation and ezrelation list field types) in which pass available parameter to FT block. See https://github.com/ezsystems/ezpublish-kernel/pull/2403/files#diff-a69bf20f91185b4b1c044ed1b71d5bceR41

AD3) No changes here.

AD4) No changes here. I'm missing proper API in UDW to be able to do this.

AD5) Behavior has been aligned with the ezimage field type. You cannot drop file which are not images into ezimageasset FT, also proper filter is now active by default in the file select dialog.

When you try to force upload of non-image file the "The file is not valid image" error will be displayed:

AD6) In this case the following error will be displayed:

barbaragr · 2018-09-06T10:02:13Z

AD I Image is still visible after deleting Image used in ImageAssets field

Create Content Type with ImageAsset FieldType
Go to Content/Content structure and create new Content Item based on Content Type from step 1
Upload an image and publish
Go to Media/Images and send to Trash image from previous step
Go back to Content/Content structure and go to view mode of recently published CI
Actual result: In view mode user sees a message: Image asset is not available (related content has been deleted or insufficient permissions) but if he go to the Edit mode, he can still see the image in image asset field.

barbaragr · 2018-09-06T10:23:54Z

AD II Question:

Create Content Type with ImageAsset FieldType
Go to Content/Content structure and create new Content Item based on Content Type from step 1
Upload an image and publish
Go to Media/Images and find the image and click Edit button to go to edit mode
Remove the image from field Image (Trash button) and publish
Actual result: According to @SylvainGuittard and @adamwojs in view mode content name is displayed (with a link to open in a new tab), but when I go to edit mode ezimageasset field is empty. When I change nothing and click Publish content name with a link is still visible. Are we OK with that? Or should it be overridden and This field is empty message should be displayed?

barbaragr · 2018-09-06T11:53:53Z

AD VI Question:
User receives a message: Error while creating image asset: User does not have access to 'read' 'content' It could by misleading, because, as default, editor has got all content policies and assign limitations for Home subtree. Maybe the information message should be more general?

barbaragr · 2018-09-06T12:03:56Z

VII I can't create Landing Page

Go to Content/Content structure
Click Create and choose Landing Page
Actual result: There is no layout modal and user is unable to publish LP. Console shows: Uncaught TypeError: window.eZ.addConfig is not a function and Uncaught TypeError: Cannot read property 'config' of undefined

SylvainGuittard · 2018-09-06T13:33:01Z

Actual result: According to @SylvainGuittard and @adamwojs in view mode content name is displayed (with a link to open in a new tab), but when I go to edit mode ezimageasset field is empty. When I change nothing and click Publish content name with a link is still visible. Are we OK with that? Or should it be overridden and This field is empty message should be displayed?

Displaying This field is empty message might confuse editors. Is it the field of the current content item or the content item image? I think we should include a link like in view mode.

barbaragr · 2018-09-10T13:55:35Z

VIII Error when previewing LP after sending to trash image from image asset field

Create Content Type with ImageAsset FieldType and Landing Page
Go to Content/Content structure and create new Content Item based on Content Type from step 1
Upload an image and publish
Go to Media/Images and send to Trash image from previous step
Go back to Content/Content structure and CI created in step 3
Click Page/site to see page view and switch to edit mode
Actual result: There is an error: An exception has been thrown during the rendering of a template ("Parameter "locationId" for route "_ezpublishLocation" must match "[^/]++" ("" given) to generate a corresponding URL.").

barbaragr · 2018-09-11T11:55:26Z

src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js

+            );
+
+            this.toggleLoading(false);
+            showErrorNotification({ message });


I think that these curly braces are needless. It should be:

showErrorNotification(message);

showErrorNotification takes Error object or string.

barbaragr · 2018-09-11T13:40:59Z

All right! To sum up:
AD I - OK
AD II - OK
AD III - works fine, updated spec (Discard of the parent content item using the image asset)
AD IV - follow up: https://jira.ez.no/browse/EZP-29589
AD V - OK
AD VI - Probably this will fix it ezsystems/ezpublish-kernel#2408 (I will check after merge)
AD VII - OK
AD VIII - OK

I didn't check DBP (blocked by: https://jira.ez.no/browse/EZEE-2308) and translations (blocked by: https://jira.ez.no/browse/EZEE-2316)

barbaragr

Ready to merge @alongosz

Co-authored-by: Dawid Parafiński <[email protected]> Co-authored-by: Jakub Brzegowski <[email protected]>

Seem already resolved

This comment has been minimized.

Sign in to view

adamwojs changed the title ~~[WIP] EZP-29104: Impl. ImageAsset field type~~ EZP-29104: Impl. ImageAsset field type Jul 27, 2018

adamwojs requested review from lserwatka, mikadamczyk, sunpietro, Nattfarinn, webhdx, tischsoic, dew326 and ViniTou July 27, 2018 11:47

This comment has been minimized.

Sign in to view

dew326 requested changes Jul 27, 2018

View reviewed changes

tischsoic approved these changes Jul 27, 2018

View reviewed changes

dew326 requested changes Jul 31, 2018

View reviewed changes

webhdx suggested changes Jul 31, 2018

View reviewed changes

mikadamczyk requested changes Aug 1, 2018

View reviewed changes

dew326 requested changes Aug 2, 2018

View reviewed changes

dew326 previously requested changes Aug 3, 2018

View reviewed changes

mikadamczyk approved these changes Aug 6, 2018

View reviewed changes

webhdx approved these changes Aug 7, 2018

View reviewed changes

This comment has been minimized.

Sign in to view

ViniTou mentioned this pull request Aug 8, 2018

EZP-29408: As an editor I want to delete a content item with an image asset field #591

Merged

2 tasks

barbaragr self-assigned this Aug 22, 2018

barbaragr requested changes Aug 24, 2018

View reviewed changes

barbaragr reviewed Sep 11, 2018

View reviewed changes

barbaragr approved these changes Sep 11, 2018

View reviewed changes

EZP-29104: Implemented UI for ImageAsset Field Type

dc757d2

Co-authored-by: Dawid Parafiński <[email protected]> Co-authored-by: Jakub Brzegowski <[email protected]>

alongosz changed the title ~~EZP-29104: Impl. ImageAsset field type~~ EZP-29104: Implemented UI for ImageAsset Field Type Sep 12, 2018

alongosz merged commit 6db696b into ezsystems:master Sep 12, 2018

adamwojs mentioned this pull request Sep 13, 2018

Recovered \EzSystems\EzPlatformAdminUi\Form\Factory\FormFactory::updateUserSetting method #620

Merged

2 tasks

SylvainGuittard mentioned this pull request Sep 14, 2018

EZP-29599: Improved spacing among field types in Edit view #613

Merged

2 tasks

mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022

IBX-3872: Fix dropdown popover inside modal (#580)

98cf53b

		const imageAssetMapping = eZ.adminUiConfig.imageAssetMapping;

		class EzImageAssetPreviewField extends eZ.BasePreviewField {


		{% set widget_container_block = block('ezplatform_fieldtype_ezimageasset_widget_container') %}

		{{ block('form_row_fieldtype') }}

EZP-29104: Implemented UI for ImageAsset Field Type #580

EZP-29104: Implemented UI for ImageAsset Field Type #580

Conversation

adamwojs commented Jul 26, 2018 • edited Loading

Checklist:

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamwojs commented Jul 31, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dew326 commented Aug 1, 2018

webhdx commented Aug 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamwojs commented Aug 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamwojs commented Aug 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

barbaragr commented Aug 23, 2018 • edited Loading

barbaragr left a comment

Choose a reason for hiding this comment

SylvainGuittard commented Sep 5, 2018

adamwojs commented Sep 5, 2018 • edited Loading

ViniTou commented Sep 5, 2018

adamwojs commented Sep 6, 2018

barbaragr commented Sep 6, 2018 • edited Loading

barbaragr commented Sep 6, 2018 • edited Loading

barbaragr commented Sep 6, 2018

barbaragr commented Sep 6, 2018

SylvainGuittard commented Sep 6, 2018

barbaragr commented Sep 10, 2018 • edited Loading

barbaragr Sep 11, 2018 • edited Loading

Choose a reason for hiding this comment

barbaragr commented Sep 11, 2018

barbaragr left a comment

Choose a reason for hiding this comment

adamwojs commented Jul 26, 2018 •

edited

Loading

barbaragr commented Aug 23, 2018 •

edited

Loading

adamwojs commented Sep 5, 2018 •

edited

Loading

barbaragr commented Sep 6, 2018 •

edited

Loading

barbaragr commented Sep 6, 2018 •

edited

Loading

barbaragr commented Sep 10, 2018 •

edited

Loading

barbaragr Sep 11, 2018 •

edited

Loading