EZEE-2181: Improve UDW branch switching #563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is required for Page Builder, otherwise the tests will be failing soon 😢
Problem
What happens:
in Collection Block scenario, the following items are picked (one after another): 'Home,Home/eZ Platform,Media/Images`.
Sometimes it fails when trying to select the last item: I believe it's because we have to switch the parent UDW path (from Home to Media), but for a brief moment before the switch is done the Home items are still displayed. So, in a timeline:
(example: http://recordit.co/yPeHbBf4Xl)
If Behat tries to interact with the displayed elements in Phase 3, it won't find the searched element by text and the tests will fail.
Potential solution
This PR tries to counteract this behaviour by waiting until the loading spinner in UDW disappears. It works locally, I didn't have time to setup this PR as a dependency in Page Builder.
Checklist:
$ composer fix-cs
)