Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZEE-2111: Landing Page field is visible while creating new Page with COTF #530

Merged

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Jun 21, 2018

Question Answer
Tickets https://jira.ez.no/browse/EZEE-2111
Requies ezsystems/ezplatform-page-builder#98
Bug fix? yes
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This PR exposes SiteAccess-aware setting to inject custom Twig Form Theme into Admin UI Content edit forms.

Usage:

ezpublish:
  system:
     admin_group: # configuration per SiteAccess or SiteAccess group
         admin_ui_forms:
             content_edit_form_templates: 
                 - { template: 'my_template.html.twig', priority: 0 }

The higher the priority, the higher the template will be placed on the list.

Checklist:

  • Create SiteAccess-aware settting
  • Create default configuration for the new setting.
  • Expose set Form Themes list in the admin_ui_config.contentEditFormTemplates Twig global variable.
  • Introduce priorities to injected templates.
  • Create unit test for mapping prioritized templates.
  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@alongosz alongosz changed the title EZEE-2111: Landing Page field is visible while creating new Page with COTF [WiP] EZEE-2111: Landing Page field is visible while creating new Page with COTF Jun 21, 2018
@alongosz alongosz force-pushed the ezee-2111-expose-sa-form-templates-setting branch from df4812e to 1323384 Compare June 22, 2018 07:58
To be configured using:

ezpublish:
    system:
        <scope>:
            admin_ui_forms:
                content_edit_form_templates:
@alongosz alongosz force-pushed the ezee-2111-expose-sa-form-templates-setting branch from 1323384 to 987ccf8 Compare June 22, 2018 08:51
@alongosz alongosz changed the title [WiP] EZEE-2111: Landing Page field is visible while creating new Page with COTF EZEE-2111: Landing Page field is visible while creating new Page with COTF Jun 22, 2018
@alongosz
Copy link
Member Author

Note: I'm gonna change config to allow prioritizing templates, as agreed discussing it internally

@alongosz alongosz force-pushed the ezee-2111-expose-sa-form-templates-setting branch from 987ccf8 to 4c16b48 Compare June 22, 2018 11:19
@alongosz alongosz force-pushed the ezee-2111-expose-sa-form-templates-setting branch from 4c16b48 to b18fb8b Compare June 22, 2018 11:24
@alongosz
Copy link
Member Author

@webhdx @mikadamczyk @Nattfarinn PR updated with support for prioritized templates and unit test checking that.

@lserwatka lserwatka merged commit 3dc6bbe into ezsystems:master Jun 22, 2018
@alongosz alongosz deleted the ezee-2111-expose-sa-form-templates-setting branch June 22, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants