Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EZP-29299] Icons review & update, follow-up #523

Merged
merged 1 commit into from
Jun 21, 2018
Merged

[EZP-29299] Icons review & update, follow-up #523

merged 1 commit into from
Jun 21, 2018

Conversation

inakijv
Copy link
Contributor

@inakijv inakijv commented Jun 19, 2018

Question Answer
Tickets EZP-29299
Bug fix? no
New feature? no
BC breaks? no
Tests pass? no
Doc needed? no
License GPL-2.0

Most important aspect:

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@inakijv
Copy link
Contributor Author

inakijv commented Jun 19, 2018

Ping @dew326

@dew326
Copy link
Member

dew326 commented Jun 20, 2018

We also need new icons (block-add, landingpage-preview, price, users-personalization, users-select) to be part of the ez-icons.svg file.

@inakijv
Copy link
Contributor Author

inakijv commented Jun 21, 2018

Updated based on review.

@sunpietro sunpietro merged commit 2831ac3 into ezsystems:master Jun 21, 2018
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
@OstafinL
IBX-3459: js error when trying create content type without defined fi…
7e5da3d 
…elds (#523)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dew326 dew326 dew326 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inakijv @dew326 @sunpietro