Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-29311: Implement permissions for Change main Location in Locations tab #519

Merged
merged 1 commit into from
Jun 20, 2018
Merged

EZP-29311: Implement permissions for Change main Location in Locations tab #519

merged 1 commit into from
Jun 20, 2018

Conversation

mikadamczyk
Copy link
Contributor

Question Answer
Tickets https://jira.ez.no/browse/EZP-29311
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

screen shot 2018-06-19 at 2 46 09 pm

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mikadamczyk mikadamczyk self-assigned this Jun 19, 2018
@m-tyrala
Copy link
Contributor

@mikadamczyk I'll check it, but there are some conflicts to resolve as well.

@m-tyrala m-tyrala self-assigned this Jun 19, 2018
m-tyrala
m-tyrala approved these changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@m-tyrala m-tyrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving aside the need for rebase, everything seems to be fine.
QA approve

@m-tyrala m-tyrala removed their assignment Jun 20, 2018
@lserwatka lserwatka merged commit 4139a67 into ezsystems:master Jun 20, 2018
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
@dew326
IBX-3427: Removed border from disabled state in tertiary buttons (#519)
779d4fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-tyrala m-tyrala m-tyrala approved these changes

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@adamwojs adamwojs Awaiting requested review from adamwojs

@webhdx webhdx Awaiting requested review from webhdx

@dew326 dew326 Awaiting requested review from dew326

@ViniTou ViniTou Awaiting requested review from ViniTou

@sunpietro sunpietro Awaiting requested review from sunpietro

Assignees

@mikadamczyk mikadamczyk

Labels
QA approved Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikadamczyk @m-tyrala @lserwatka