Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-29028: Subtree should be shown in a new line #435

Merged
merged 4 commits into from
Apr 3, 2018
Merged

EZP-29028: Subtree should be shown in a new line #435

merged 4 commits into from
Apr 3, 2018

Conversation

mikadamczyk
Copy link
Contributor

Question Answer
Tickets https://jira.ez.no/browse/EZP-29028
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

screen shot 2018-03-29 at 3 17 15 pm

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mikadamczyk mikadamczyk self-assigned this Mar 30, 2018
@mikadamczyk mikadamczyk mentioned this pull request Mar 30, 2018
Closed
dew326
dew326 requested changes Mar 30, 2018
View reviewed changes
Copy link
Member

@dew326 dew326 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only because of the order of HTML elements. You should rather add label subtree and button inside some block element (for example div). This will prevent us from having the same problem when something will be added to the form.

@ViniTou
Copy link
Contributor

ViniTou commented Mar 30, 2018

@dew326
Should this go to master or 1.1?

@dew326
Copy link
Member

dew326 commented Mar 30, 2018

Every bug fix should go to the last release (if occurs). Currently, all should be merged into 1.1.

@mikadamczyk mikadamczyk changed the base branch from master to 1.1 March 30, 2018 13:53
@barbaragr barbaragr self-assigned this Apr 3, 2018
@lserwatka lserwatka merged commit ec1bb68 into ezsystems:1.1 Apr 3, 2018
@lserwatka
Copy link
Member

@mikadamczyk please merge up to master.

ViniTou pushed a commit that referenced this pull request May 12, 2023
@GrabowskiM @mnocon
IBX-2925: [D&D] Functionality and design improvements (#435)
6f249aa 
Co-authored-by: Marek Nocoń <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webhdx webhdx webhdx approved these changes

@dew326 dew326 dew326 approved these changes

@barbaragr barbaragr barbaragr approved these changes

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees

@mikadamczyk mikadamczyk

@barbaragr barbaragr

Labels
QA approved Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikadamczyk @ViniTou @dew326 @lserwatka @webhdx @barbaragr