Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-28682: Error 404 after fast double click #403

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

dew326
Copy link
Member

@dew326 dew326 commented Mar 19, 2018

Question Answer
Tickets https://jira.ez.no/browse/EZP-28682 https://jira.ez.no/browse/EZP-28685
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Ready for Code Review

@sunpietro
Copy link
Contributor

So the the editorial UX will be like this (finally):
you-had-one-chance

Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for actions performed from the "right menu" (publish, create, etc - with the exception of actions that invoke an additional modal like "empty trash" or "send to trash")

It still fails after a quick double click on a modal, examples:

  • deleting a section from Section details tab (double-click on "Delete" in modal)
  • deleting an Assignment from Role
  • deleting a Language
  • deleting a Content Type Group
  • deleting a field type from Content Type (results in a message: This form should not contain extra fields. 🤔 )
  • deleting a Content Type
  • deleting a user
  • deleting an object state
  • deleting an object state group

@dew326
Copy link
Member Author

dew326 commented Mar 20, 2018

ping @mnocon
@sunpietro I know, I know important

Copy link
Contributor

@sunpietro sunpietro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a pain in my heart I approve

@sunpietro
Copy link
Contributor

Everytime I see !important in the CSS code, a little kitten dies :(

kitten-not-happy-ts-537866755

Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lserwatka lserwatka merged commit 1c8986f into ezsystems:master Mar 20, 2018
@dew326 dew326 deleted the dbl-click branch March 21, 2018 07:46
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
Merge IBX-2275: Refactor UDW configuration subscribers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants