Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZEE-1610: Fix click with overlay method #348

Merged
merged 1 commit into from
Feb 16, 2018
Merged

EZEE-1610: Fix click with overlay method #348

merged 1 commit into from
Feb 16, 2018

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Feb 16, 2018 •
edited
Loading

Question Answer
Tickets EZEE-1610
Bug fix? actually yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This PR introduces a quick fix for Studio tests:

  1. The click was never retried (because of missing namespace 😞 )
  2. Changed a bit how the method works: now the number of retries isn't fixed at 2 but can be specified, I've chosen 5 as arbitrary value - in most cases it won't make a difference, but in some edge-spinner-is-everywhere-cases it should help.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ezsystems ezsystems deleted a comment from ezrobot Feb 16, 2018
@mnocon mnocon closed this Feb 16, 2018
@mnocon mnocon reopened this Feb 16, 2018
@mnocon mnocon changed the title [WIP] EZEE-1610: Fix click with overlay method EZEE-1610: Fix click with overlay method Feb 16, 2018
micszo
micszo approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edge-spinner-is-everywhere-cases <3

@lserwatka lserwatka merged commit 5443078 into ezsystems:1.0 Feb 16, 2018
m-tyrala
m-tyrala reviewed Feb 16, 2018
View reviewed changes
Copy link
Contributor

@m-tyrala m-tyrala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--$numberOfRetries; if ($numberOfRetries > 0) { throw $e; }

this if always throws error if $numberOfRetries is greater than 1

@mnocon mnocon mentioned this pull request Feb 16, 2018
Merged
2 tasks
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
@OstafinL
IBX-2177: Page builder - Error state on icon (#348)
daef05e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-tyrala m-tyrala m-tyrala left review comments

@micszo micszo micszo approved these changes

@barbaragr barbaragr Awaiting requested review from barbaragr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnocon @micszo @m-tyrala @lserwatka