EZP-28172 behat specs for content types #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
changed the title
mnocon
requested changes
Feb 8, 2018
| 'plusButton' => '.ez-icon-create', | ||
| 'trashButton' => '.ez-icon-trash', | ||
| 'editButton' => 'tr:nth-child(%s) a[title=Edit]', | ||
| 'listHeader' => '.ez-table-header__headline', | ||
| 'tableHeader' => 'th', | ||
| //'horizontalHeaders' => '.ez-table-header + .table,form thead th', |
| @@ -81,15 +75,25 @@ public function clickListElement(string $name): void | |||
| $this->context->getElementByText($name, $this->fields['listElementLink'])->click(); | |||
| } | |||
|
|
|||
| public function isElementOnList(string $name): bool | |||
| public function isLinkedItemOnList(string $name): bool | |||
There was a problem hiding this comment.
Just to be sure: it allows only to check whether an element which is a link is present? maybe isLinkElementOnList? (At first I was wondering to what should this item be linked)
| throw new ElementNotFoundException($this->context->getSession(), 'table header', $this->fields['listHeader']); | ||
| } | ||
| } | ||
|
|
||
| public function verifyVisibility(): void | ||
| { | ||
| $this->context->waitUntilElementIsVisible($this->fields['plusButton'], $this->defaultTimeout); |
There was a problem hiding this comment.
Because this same structure is also in ContentTypePage, and there's no buttons, only tables with informations, so I leaved only list header checking.
|
|
||
| public function selectFieldDefinition(string $fieldName) | ||
| { | ||
| $this->context->findElement('#' . $this->fields['fieldTypesList'], $this->defaultTimeout)->selectOption($fieldName); |
There was a problem hiding this comment.
Maybe specify fieldTypesList with the # already?
| $this->context->findElement($this->fields['list']) | ||
| ); | ||
|
|
||
| return $this->context->findElement(sprintf($this->fields['tableCell'], $rowPosition, '2'))->getText(); |
There was a problem hiding this comment.
You could use %d in format definition and pass 2 as a number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)