[EZP-28683] Removes asterisk sign from labels when content editing #327
Conversation
| @@ -172,9 +172,15 @@ | |||
| content: ': '; | |||
| } | |||
|
|
|||
| &.required { | |||
| &.required:not(.ez-data-source__label) { | |||
There was a problem hiding this comment.
I think we can avoid adding :not(.ez-data-source__label) here, as the next selector is a stronger than this one.
| &:after { | ||
| content: '*: '; | ||
| } | ||
| } | ||
|
|
||
| &.required.ez-data-source__label { |
There was a problem hiding this comment.
Cannot we just drop using this mixin for .ez-data-source__label? https://github.com/ezsystems/ezplatform-admin-ui/blob/master/src/bundle/Resources/public/scss/fieldType/edit/_base-field.scss#L3
And just add &:after {content: ": "} https://github.com/ezsystems/ezplatform-admin-ui/blob/master/src/bundle/Resources/public/scss/fieldType/edit/_base-field.scss#L51 or in a twig?
Because for me it seems like generic mixin gets information about where is used and it's no longer generic. ;)
There was a problem hiding this comment.
Thought about this, but then it needs to be somehow duplicated in
I am right?
|
@sunpietro |
At first wanted to edit in _base-fields.scss but then it turns out that asterisk is added also in _forms.scss.
Dont know if it should be somehow excluded from .ez-data-source__label instead.
Checklist:
$ composer fix-cs)