-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-28766: Notification gets covered by radio-button in content editor #322
EZP-28766: Notification gets covered by radio-button in content editor #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try to reproduce the case when the richtext fieldtype's menu bar is appearing below the notification bar? Does it cover the case?
@@ -3,6 +3,7 @@ | |||
bottom: 0; | |||
width: 100%; | |||
line-height: 2.25; | |||
z-index: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dew326 is the value big enough? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@micszo it's big enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will work, but for me, it should be something bigger like 50000 (UDW has 99999), just for safety.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And what if someone wants to create an element that is before all other but behind the notifications. With z-index 1 he has no space for adding rule to own element
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dew326 ok, safety first. I will change to 50000
@barbaragr this one should be quick. |
As @sunpietro mentioned it is also cover the case when the rich text field type menu bar is appearing below the notification bar |
1e4d576
to
e37e2b2
Compare
@sunpietro on 2.0 I can confirm that rich text menu and |
But, let's fix it as separate PR. I'm merging this one. |
The way I understood @mikadamczyk this fix should cover both cases. 🙂 |
OK, good 👍 |
…nothing happens (#322)
Notification gets covered by radio-button in content editor.
Checklist:
$ composer fix-cs
)