Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-28766: Notification gets covered by radio-button in content editor #322

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Jan 23, 2018

Question Answer
Tickets https://jira.ez.no/browse/EZP-28766
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Notification gets covered by radio-button in content editor.

screen shot 2018-01-23 at 10 30 59 am

screen shot 2018-01-23 at 11 03 33 am

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

Copy link
Contributor

@sunpietro sunpietro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try to reproduce the case when the richtext fieldtype's menu bar is appearing below the notification bar? Does it cover the case?

@@ -3,6 +3,7 @@
bottom: 0;
width: 100%;
line-height: 2.25;
z-index: 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dew326 is the value big enough? 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micszo it's big enough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will work, but for me, it should be something bigger like 50000 (UDW has 99999), just for safety.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what if someone wants to create an element that is before all other but behind the notifications. With z-index 1 he has no space for adding rule to own element

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dew326 ok, safety first. I will change to 50000

@micszo
Copy link
Member

micszo commented Jan 23, 2018

@barbaragr this one should be quick.

@mikadamczyk
Copy link
Contributor Author

As @sunpietro mentioned it is also cover the case when the rich text field type menu bar is appearing below the notification bar

@mikadamczyk mikadamczyk force-pushed the ezp-28766-notification-gets-covered-by-radio-button-in-content-editor branch from 1e4d576 to e37e2b2 Compare January 23, 2018 09:58
@micszo
Copy link
Member

micszo commented Jan 23, 2018

@sunpietro on 2.0 I can confirm that rich text menu and + button are also affected (ticket updated).

@lserwatka
Copy link
Member

But, let's fix it as separate PR. I'm merging this one.

@micszo
Copy link
Member

micszo commented Jan 23, 2018

The way I understood @mikadamczyk this fix should cover both cases. 🙂

@lserwatka
Copy link
Member

OK, good 👍

@lserwatka lserwatka merged commit 4b58769 into ezsystems:1.0 Jan 23, 2018
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants