EZP-28172 Behat Covering of Content Types #312

m-tyrala · 2018-01-16T09:14:07Z

Question	Answer
Tickets	EZP-28172 EZP-28693
Bug fix?	no
New feature?	no
BC breaks?	no
Tests pass?	yes
Doc needed?	no
License	GPL-2.0

Feature file with scenarios for Content Types testing

Checklist:

Coding standards ($ composer fix-cs)
Ready for Code Review

mnocon

Looks nice!

Few things:

There are some small grammar issues (i should be capitalised, im -> I'm)
It's 19 scenarios here, could we split them into smaller groups? There are actions on Content Type Groups and Content Types, so that might be a start (not sure about the mixed ones 🤔 )

mnocon · 2018-01-16T13:28:26Z

src/features/ContentTypes.feature

@@ -0,0 +1,161 @@
+Feature: Content types management
+  As a administrator


Nitpick: As an administrator

mnocon · 2018-01-16T13:29:13Z

src/features/ContentTypes.feature

+Feature: Content types management
+  As a administrator
+  In order to customize my eZ installation
+  I want to manage my Content types structure.


Nitpick: Content Types 😛

mnocon · 2018-01-16T13:39:26Z

src/features/ContentTypes.feature

+
+  @javascript @common
+  Scenario: Content Type Groups context is available
+    Given that im in context of Content Type Groups


Usually I'd use "Given that I'm on Content Type Groups page" (or something like that), I haven't seen the syntax "I'm in context of" yet - both look ok, guess we will have to decide which one we prefer/which is clearer.

BTW: I'd drop the "that" (no matter which form is chosen).

mnocon · 2018-01-16T13:43:32Z

src/features/ContentTypes.feature

+  @javascript @common
+  Scenario: Changes can be discarded while creating new Content Type Group
+    Given that im in context of Content Type Groups
+    When i click plus button


I'd consider changing it to "I start creating a new Content Type Group" - it would have the same code implementation, but we're expressing the intention (and not the exact action that happens).

mnocon · 2018-01-16T13:47:25Z

src/features/ContentTypes.feature

+      And click Discard Changes
+    Then i shoud be redirected to Content Types context
+      And i should see Content Type Groups list
+      And there's nothing new on the list


That's nice!

mnocon · 2018-01-17T07:31:29Z

src/features/ContentTypes.feature

+  @javascript @common
+  Scenario: Content type can be edited
+    Given that i'm in context of Content Type update form
+      And there's Content Type on the list


Looks like it shouldn't be here.

mnocon · 2018-01-17T07:32:54Z

src/features/ContentTypes.feature

+  Scenario: Content type can be deleted from Content Type Group
+    Given that i'm in context of Content Type Group
+    When i click on checkbox left to Content Type
+      And i click on trash icon


We could combine these two steps into one: I delete Content Type X

mnocon · 2018-01-17T07:40:17Z

src/features/ContentTypes.feature

+
+  @javascript @common
+  Scenario: Changes of Content Type are visible in Content Type Group context
+    Given that i'm in context of just edited Content Type


Something to discuss: to what extent do we plan to allow Scenarios to rely on each other?
If I read it correctly, it depends on the previous Scenario (and maybe we could simply Edit another Content Type in this test).

mnocon · 2018-01-17T07:43:58Z

src/features/ContentTypes.feature

+    Given that im in context of Content Type Groups
+    When i click plus button
+      And fill Name field
+      And click Discard Changes


I like the margins for And, good idea

mnocon · 2018-01-17T07:48:01Z

src/features/ContentTypes.feature

+  Scenario: Non-empty Content type group cannot be deleted
+    Given that i'm in context of Content Type Groups
+    When Content Type Group is non-empty
+    Then i can't click on checkbox left to this Content Type Group


I'd change to Content Type Group cannot be selected

mnocon · 2018-01-25T10:47:29Z

behat_suites.yml

@@ -4,10 +4,13 @@ adminui:
    suites:
        adminui:
            paths:
-                - '%paths.base%/vendor/ezsystems/ezplatform-admin-ui/src/features'
+                - '%paths.base%/vendor/ezsystems/ezplatform-admin-ui/features'


Nice! 😄 We should close https://jira.ez.no/browse/EZP-28693 after it's merged, for clarity

mnocon · 2018-01-25T10:48:41Z

features/ContentTypeGroup.feature

+  As an administrator
+  In order to customize my eZ installation
+  I want to manage my Content types structure.
+


First two steps of every scenario can be extracted to a Background section:

Background: Given I am logged as "admin" And I go to "Content Types" in "Admin" tab

mnocon · 2018-01-25T12:32:14Z

src/lib/Behat/BusinessContext/AdminUpdateItemContext.php

+    }
+
+    /**
+     * @When I click :button in right menu


Isn't it already in Content Context? I click on the edit action bar button "Publish"

mnocon · 2018-01-25T12:37:48Z

src/lib/Behat/BusinessContext/AdminUpdateItemContext.php

+     */
+    public function iFillField(string $fieldName, string $value)
+    {
+        if ($this->utilityContext->getElementByText(sprintf(/*"\"%s\"",*/ $fieldName), '.form-control-label') !== null) {


There is "I set field to X" in Content Context, can't it be used? +ContentContext looks like a better place for this Step

IMHO we can change getElementByText to throw an exception in case it should return null, we could avoid writing this if/else every time.

sprintf can be omitted

mnocon · 2018-01-25T12:46:22Z

src/lib/Behat/PageElement/AdminList.php

+        $this->context->getElementByText($name, $this->fields['listElementLink'])->click();
+    }
+
+    public function checkListElement(string $name): bool


It returns bool, I'd consider renaming it to something indicating that (isElementPresent/isElementOnList?)

mnocon · 2018-01-26T08:54:47Z

src/lib/Behat/PageElement/AdminList.php

+
+    private function assertProperList(): void
+    {
+        if (strcmp($this->listHeader, $this->context->findElement($this->fields['listHeader'], 5)->getText()) !== 0) {


We might: use === for comparison and replace 5 with $this->defaultTimeout (which is also equal 5)

mnocon · 2018-01-26T08:58:58Z

src/lib/Behat/PageElement/Breadcrumb.php

+
+class Breadcrumb extends Element
+{
+    private $fields = ['breadcrumbItem' => '.breadcrumb-item',


I like storing the selectors in an array 👍

mnocon · 2018-01-26T09:11:37Z

src/lib/Behat/PageElement/ElementFactory.php

+class ElementFactory
+{
+    /**
+     * Creates a Page object based on given Page Name.


I know you know this, just so that it does not get lost: remember about amending PHPDocs 😛

mnocon · 2018-01-26T09:12:46Z

src/lib/Behat/PageObject/ContentTypeGroupsPage.php

+    /**
+     * @var \EzSystems\EzPlatformAdminUi\Behat\PageElement\UpperMenu
+     */
+    public $upperMenu;


Maybe we can move it to Page?

mnocon · 2018-01-26T09:13:16Z

src/lib/Behat/PageElement/AdminList.php

+
+    public function verifyVisibility(): void
+    {
+        $this->context->checkVisibilityByClass($this->fields['plusButton']);


It won't work: checkVisibility returns bool (does not throw).
We can use:
Assert:assertTrue(checkVisibilityByClass());
or (assuming element exists):
Assert:assertTrue(findElement(selector)->isVisible());

I guess the name is misleading, we might want to change that.

lserwatka · 2018-01-26T09:43:12Z

You must re-base here.

mnocon · 2018-01-31T13:00:16Z

src/lib/Behat/BusinessContext/AdministrationContext.php

+            $msg = ' non';
+        }
+
+        if(($contentsCount !== '0') === $empty){


I'd rename the param to shouldBeEmpty (and extract $contentsCount !== '0' to a new variable, isEmpty).

micszo · 2018-01-31T09:19:27Z

features/ContentTypeGroup.feature

    Given I am logged as "admin"
      And I go to "Content Types" in "Admin" tab
+
+  @javascript @common
+  Scenario: Content Type Groups context is available
    Then I should see "Content Type Groups" list


I'm wondering if we need this scenario because it is implicitly checked by the other more advanced ones anyway.

micszo · 2018-01-31T09:39:54Z

features/ContentTypeGroup.feature

    Then I should see "Content Type Groups" list

  @javascript @common
  Scenario: Changes can be discarded while creating new Content Type Group
-    Given I am logged as "admin"
-      And I go to "Content Types" in "Admin" tab
    When I start creating new "Content Type Group"


Scenario starting from When doesn't look right - what do you think guys? (Given only in background)

Both version would look fine to me (both are readable).

mnocon · 2018-01-31T13:10:34Z

src/lib/Behat/PageObject/PageObjectFactory.php

     *
     * @return LoginPage|DashboardPage|ContentStructurePage|ContentTypeGroupsPage|UpdateItemPage to interact with
     */
-    public static function createPage(UtilityContext $context, string $pageName): Page
+    public static function createPage(UtilityContext $context, string $pageName, string $parameter = null): Page


Maybe it should be a dictionary? I can see us adding "parameter2" soon 😛

mnocon · 2018-01-31T13:18:17Z

src/lib/Behat/PageElement/Notification.php

+
+    public function verifySuccessMessage(string $itemType, string $itemName, string $action): void
+    {
+        printf($this->context->findElement($this->fields['successAlert'])->getText());


Please remove.

mnocon · 2018-01-31T13:48:33Z

src/lib/Behat/PageElement/Notification.php

+ * User: maciejtyrala
+ * Date: 26/01/2018
+ * Time: 11:36
+ */


Please change (Storm can be configured to add proper headers automatically).

mnocon · 2018-01-31T13:49:19Z

src/lib/Behat/PageElement/Notification.php

+
+    public function verifyVisibility(): void
+    {
+        $this->context->waitUntilElementIsVisible($this->fields['successAlert'], $this->defaultTimeout);


I don't think it should be based on successAlert (we can expect various alerts).

You're right, I'll fix it. I was assume that there will be potentially more success alerts than the failure ones.
Yet, it's not something critical, because this element isn't assigned to any page, just like upperMenu, so verifyVisibility method will be call only on demand.

mnocon · 2018-01-31T13:50:57Z

src/lib/Behat/PageElement/Notification.php

+    public function verifySuccessMessage(string $itemType, string $itemName, string $action): void
+    {
+        printf($this->context->findElement($this->fields['successAlert'])->getText());
+        $this->context->assertElementContainsText($this->fields['successAlert'], sprintf("%s '%s' %s.",$itemType, $itemName, $action));


Should it happen here? I'd place the assertion in NotificationContext (and simply change this one to "getText").

mnocon · 2018-01-31T13:55:43Z

src/lib/Behat/PageElement/Dialog.php

-    protected $fields = ['yesButton' => '',
-                        'noButton' => '', ];
+    protected $fields = ['confirm' => '.btn--trigger',
+                        'decline' => '.btn--no', ];
    /** @var string Name by which Page is recognised */


Page => Element 😛

mnocon · 2018-01-31T14:28:33Z

features/ContentTypeGroup.feature

    Then I should see "Content Type Groups" list

  @javascript @common
  Scenario: Changes can be discarded while creating new Content Type Group
-    Given I am logged as "admin"
-      And I go to "Content Types" in "Admin" tab
    When I start creating new "Content Type Group"


Both version would look fine to me (both are readable).

mnocon · 2018-01-31T15:01:02Z

src/lib/Behat/PageElement/AdminList.php

    {
        return $this->context->getElementByText($name, $this->fields['listElementLink']) !== null;
    }

-    public function verifyVisibility(): void
+    public function checkListItemAttribute(string $name, string $header): string


This one returns texts (it does not check anything) - can't it be getTableCell($rowName, $columnName) / (getAdminTableCellValue)?.

To be honest, I don't like methods with "check".
We have:
checkListItemAttribute which does not check anything
checkContentsStatus which throws
checkListElementExists, checkListElementSelectable which do not throw and return bool

Maybe we could follow the following convention:

if it throws: use assert/verify (verifyAssignedContentCount?) in the name?

if it returns bool: sort-of-a-question: isElementOnTheList, isElementSelectable

What do you think?

You're right, it might be confusing and it's a bad inconsistency.
I'll fix it. Convention that you mention looks good for me.

mnocon

Looks nice!

micszo

👍

m-tyrala · 2018-02-05T13:23:03Z

@lserwatka ready for merge

lserwatka · 2018-02-05T18:35:57Z

@webhdx @Nattfarinn @alongosz @mikadamczyk @ViniTou Could you Guys have a look on PHP code?

mikadamczyk

Please, fix SC and Type Hinting

mikadamczyk · 2018-02-06T13:00:27Z

src/lib/Behat/PageObject/PageObjectFactory.php

-use EzSystems\StudioUIBundle\Tests\Behat\PageObject\LandingPageEditorPage;
+use EzSystems\EzPlatformAdminUi\Behat\Helper\UtilityContext;
+
+//use EzSystems\StudioUIBundle\Tests\Behat\PageObject\LandingPageEditorPage;


Comment to remove

mikadamczyk · 2018-02-06T13:06:33Z

src/lib/Behat/BusinessContext/AdministrationContext.php

+
+class AdministrationContext extends BusinessContext
+{
+    private $itemCreateMapping = ['Content Type Group' => ContentTypeGroupsPage::PAGE_NAME,


I think we should follow code style also in tests

private $itemCreateMapping = [ 'Content Type Group' => ContentTypeGroupsPage::PAGE_NAME, 'Content Type' => '', .... 'User' => '', ];

mikadamczyk · 2018-02-06T13:09:53Z

src/lib/Behat/BusinessContext/AdministrationContext.php

+                        'Role' => '',
+                        'Section' => '',
+                        'User' => '', ];
+    private $emptyHeaderMapping = ['Content Type Groups' => 'Content Types count',


Same CS here

mikadamczyk · 2018-02-06T13:11:19Z

src/lib/Behat/BusinessContext/AdministrationContext.php

+     * @Then there's :listElementName on :page list
+     * @Then there's :listElementName on :parameter :page list
+     */
+    public function isElementOnTheList($listElementName, $page): void


Missing Type Hinting?

mikadamczyk · 2018-02-06T13:11:37Z

src/lib/Behat/BusinessContext/AdministrationContext.php

+     * @Then there's no :listElementName on :page list
+     * @Then there's no :listElementName on :parameter :page list
+     */
+    public function isElementNotOnTheList($listElementName, $page, $parameter = null): void


Type Hinting?

mikadamczyk · 2018-02-06T13:16:52Z

src/lib/Behat/BusinessContext/AdministrationContext.php

+     */
+    public function isElementNotOnTheList($listElementName, $page, $parameter = null): void
+    {
+        $actual = PageObjectFactory::createPage($this->utilityContext, $page, $parameter)


Better variable name?

mikadamczyk · 2018-02-06T13:23:13Z

src/lib/Behat/BusinessContext/AdministrationContext.php

+     */
+    private function verifyContentsStatus($itemName, $page, $shouldBeEmpty): void
+    {
+        $isEmpty = '0';


Better variable name?

mikadamczyk · 2018-02-06T13:24:47Z

src/lib/Behat/BusinessContext/AdministrationContext.php

+     */
+    public function itemCannotBeSelected($itemType, $itemName): void
+    {
+        $checkboxState = PageObjectFactory::createPage($this->utilityContext, $this->itemCreateMapping[$itemType])


Better variable name?

mikadamczyk · 2018-02-06T13:33:01Z

src/lib/Behat/PageElement/AdminList.php

+
+    private function verifyProperList(): void
+    {
+        if ($this->listHeader !== $this->context->findElement($this->fields['listHeader'], $this->defaultTimeout)->getText()) {


Can we extract $this->context->findElement($this->fields['listHeader'], $this->defaultTimeout)->getText() to method or variable to improve readability?

m-tyrala · 2018-02-06T14:19:30Z

Fixed

alongosz

Some nitpicks 🙃

alongosz · 2018-02-06T15:42:53Z

src/lib/Behat/BusinessContext/AdministrationContext.php

+     */
+    public function iStartCreatingNew(string $newItemType): void
+    {
+        if (!\array_key_exists($newItemType, $this->itemCreateMapping)) {


Please don't prefix functions with \. In case of built-in classes, it's fine but I rather try to add use statement for them as well.

alongosz · 2018-02-06T15:43:19Z

src/lib/Behat/BusinessContext/AdministrationContext.php

+    public function iStartCreatingNew(string $newItemType): void
+    {
+        if (!\array_key_exists($newItemType, $this->itemCreateMapping)) {
+            throw new \InvalidArgumentException(sprintf('Unrecognised item type name: %s', $newItemType));


Typo: unrecognized

alongosz · 2018-02-06T15:45:06Z

src/lib/Behat/BusinessContext/AdministrationContext.php

+        if (!$isElementOnTheList) {
+            throw new ElementNotFoundException(
+                    $this->utilityContext->getSession(),
+                    sprintf('Element "%s" is not on the %s list.', $listElementName, $page));


CS: please move ); to the new line, on the same level as throw (I'm surprised cs-fixer didn't complain ;))

alongosz · 2018-02-06T15:45:35Z

src/lib/Behat/BusinessContext/AdministrationContext.php

+        if ($isElementOnTheList) {
+            throw new ElementNotFoundException(
+                $this->utilityContext->getSession(),
+                sprintf('Element "%s" is on the %s list.', $listElementName, $page));


Same comment as above.

alongosz · 2018-02-06T15:48:26Z

src/lib/Behat/BusinessContext/AdministrationContext.php

+     *
+     * @param $itemName
+     * @param $page
+     * @param $shouldBeEmpty


Missing parameter types in PhpDoc (still required despite placing them in prototype).

alongosz · 2018-02-06T15:54:05Z

src/lib/Behat/PageElement/ElementFactory.php

+            case Notification::ELEMENT_NAME:
+                return new Notification($context);
+            default:
+                throw new \InvalidArgumentException(sprintf('Unrecognised element name: %s', $elementName));


Typo: Unrecognized

alongosz · 2018-02-06T15:57:20Z

src/lib/Behat/PageElement/Notification.php

+ */
+namespace EzSystems\EzPlatformAdminUi\Behat\PageElement;
+
+class Notification extends Element


I didn't pay attention in similar cases, but it's a good example of needed PhpDoc, stating something like "Element describing system notifications for the user". There is another feature with that name related to EE which gets us confused very often ;)

alongosz · 2018-02-06T15:58:20Z

src/lib/Behat/PageElement/UpdateForm.php

+
+    public function verifyVisibility(): void
+    {
+        // TODO: Implement verifyVisibility() method.


Same comment as previously - is it postponed for later on?

alongosz · 2018-02-06T16:13:16Z

src/lib/Behat/PageElement/ElementFactory.php

+                return new UpdateForm($context);
+            case Breadcrumb::ELEMENT_NAME:
+                return new Breadcrumb($context);
+            case Notification::ELEMENT_NAME:


This is not very SOLID, I'm also not a huge fan of static factory methods. If any new element appears, this list needs to be updated and maintained. The problem here is that we're a little bit limited due to lack of DI container.

if I were to change it - since the switch cases are really simple - I'd just avoid using factory in favor of creating of objects in-place. It actually would produce less code :-)

POV @Nattfarinn @webhdx

Actually i had the same opinion, but when i start working on automated tests, there was already PageObjectFactory, and after discussion we decided to stay with this concept. I'll be happy to discuss it again, but if it's possible, as a new task.

alongosz · 2018-02-06T16:15:43Z

src/lib/Behat/PageObject/PageObjectFactory.php

+            case UpdateItemPage::PAGE_NAME:
+                return new UpdateItemPage($context);
+            case ContentTypeGroupPage::PAGE_NAME:
+                return new ContentTypeGroupPage($context, $parameters[0]);


And I see now how the ElementFactory appeared, since here we have already existing similar code.
Still not a huge fan, but let's discuss it internally maybe.

m-tyrala · 2018-02-06T21:34:50Z

Except of "TODO" and "Factory" (which i explained above) I think I fixed all pointed problems. I hope this time everything is ok.

alongosz · 2018-02-06T21:49:43Z

Actually i had the same opinion, but when i start working on automated tests, there was already PageObjectFactory, and after discussion we decided to stay with this concept. I'll be happy to discuss it again, but if it's possible, as a new task.

Ok, that works for me 👍

m-tyrala requested review from mnocon, micszo and barbaragr January 16, 2018 09:14

mnocon reviewed Jan 17, 2018

View reviewed changes

m-tyrala changed the base branch from 1.0 to master January 25, 2018 10:13

m-tyrala changed the base branch from master to 1.0 January 25, 2018 11:48

mnocon requested changes Jan 26, 2018

View reviewed changes

m-tyrala changed the base branch from 1.0 to master January 26, 2018 10:06

m-tyrala changed the base branch from master to 1.0 January 26, 2018 10:06

mnocon reviewed Jan 31, 2018

View reviewed changes

micszo reviewed Jan 31, 2018

View reviewed changes

mnocon requested changes Jan 31, 2018

View reviewed changes

m-tyrala changed the title ~~[WIP] EZP-28172 Behat Covering of Content Types - adding scenarios prototypes~~ [WIP] EZP-28172 Behat Covering of Content Types Feb 1, 2018

mnocon approved these changes Feb 5, 2018

View reviewed changes

micszo approved these changes Feb 5, 2018

View reviewed changes

m-tyrala changed the title ~~[WIP] EZP-28172 Behat Covering of Content Types~~ EZP-28172 Behat Covering of Content Types Feb 5, 2018

m-tyrala changed the title ~~EZP-28172 Behat Covering of Content Types~~ [WIP] EZP-28172 Behat Covering of Content Types Feb 5, 2018

EZP-28172 Behat Covering of Content Types - squash changes to one commit

6146016

m-tyrala changed the title ~~[WIP] EZP-28172 Behat Covering of Content Types~~ EZP-28172 Behat Covering of Content Types Feb 5, 2018

ezsystems deleted a comment from ezrobot Feb 5, 2018

mikadamczyk requested changes Feb 6, 2018

View reviewed changes

m-tyrala added 2 commits February 6, 2018 15:02

EZP-28172 Behat Covering of Content Types - fixes after review

79c5a92

EZP-28172 Behat Covering of Content Types - fixes after review

e845397

mikadamczyk approved these changes Feb 6, 2018

View reviewed changes

alongosz requested changes Feb 6, 2018

View reviewed changes

EZP-28172 Behat Covering of Content Types - fixes after review

9613378

alongosz approved these changes Feb 6, 2018

View reviewed changes

lserwatka merged commit 86893b3 into ezsystems:1.0 Feb 6, 2018

m-tyrala deleted the ezp-28172 branch October 16, 2018 15:11

mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022

IBX-2240: Default field type name on CT create (#312)

86677ec

		@@ -0,0 +1,161 @@
		Feature: Content types management
		As a administrator

EZP-28172 Behat Covering of Content Types #312

EZP-28172 Behat Covering of Content Types #312

Conversation

m-tyrala commented Jan 16, 2018 • edited Loading

Checklist:

mnocon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lserwatka commented Jan 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mnocon left a comment

Choose a reason for hiding this comment

micszo left a comment

Choose a reason for hiding this comment

m-tyrala commented Feb 5, 2018

lserwatka commented Feb 5, 2018

mikadamczyk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m-tyrala commented Feb 6, 2018

alongosz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m-tyrala commented Feb 6, 2018

alongosz commented Feb 6, 2018

m-tyrala commented Jan 16, 2018 •

edited

Loading