Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-28660: Top menu is not adding sections when there is no children which breaks extensibility #279

Merged
merged 1 commit into from
Dec 22, 2017

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Dec 22, 2017

Question Answer
Tickets https://jira.ez.no/browse/EZP-28660
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@webhdx webhdx self-assigned this Dec 22, 2017
@lserwatka lserwatka merged commit 4c8c321 into ezsystems:master Dec 22, 2017
@emodric
Copy link
Contributor

emodric commented Dec 22, 2017

This broke Netgen Tags top menu item somehow :(

@emodric
Copy link
Contributor

emodric commented Dec 22, 2017

Probably because of added if item.children|length > 0 in the template.

@webhdx
Copy link
Contributor Author

webhdx commented Dec 22, 2017

@emodric I see. Fix incoming. Sorry ;)

@emodric
Copy link
Contributor

emodric commented Dec 22, 2017

@webhdx Thanks for the quick reaction :)

@webhdx
Copy link
Contributor Author

webhdx commented Dec 22, 2017

@emodric #288

@webhdx webhdx deleted the top_menu_persist_sections branch March 7, 2018 13:53
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants