EZP-28646: Validation alert for map location which is not required #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sunpietro
commented
Dec 21, 2017
sunpietro
commented
| Question | Answer |
|---|---|
| Tickets | https://jira.ez.no/browse/EZP-28646 |
| Bug fix? | yes/no |
| New feature? | yes/no |
| BC breaks? | yes/no |
| Tests pass? | yes/no |
| Doc needed? | yes/no |
| License | GPL-2.0 |
|
@barbaragr please, test cases with required and non-required map fields. |
dew326
reviewed
Dec 21, 2017
| @@ -19,13 +19,14 @@ | |||
| const result = { isError: false }; | |||
| const label = input.closest('.ez-data-source__field').querySelector('.ez-data-source__label').innerHTML; | |||
| const isNumber = !isNaN(value); | |||
| const isInRange = (value <= max && value >= min); | |||
| const isCorrectValue = isNumber && (value <= max && value >= min); | |||
sunpietro
force-pushed
the
EZP-28646-fix-map-validation
branch
from
d489101 to
f3877f9
Compare
mateuszdebinski
pushed a commit
that referenced
this pull request
Oct 25, 2022
Co-authored-by: Michał Grabowski <[email protected]> Co-authored-by: Marek Nocoń <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.