Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-28635: Make sure policies without limitationTypes are not editable #254

Merged
merged 1 commit into from
Dec 22, 2017
Merged

EZP-28635: Make sure policies without limitationTypes are not editable #254

merged 1 commit into from
Dec 22, 2017

Conversation

Nattfarinn
Copy link
Contributor

Question Answer
Tickets https://jira.ez.no/browse/EZP-28635
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barbaragr barbaragr self-assigned this Dec 21, 2017
@barbaragr
Copy link

The same for these:

  • Content/Reverserelatedlist
  • Content / Translations
  • Content / Urltranslator
  • Content / Pendinglist
  • Content / Restore
  • Content / Cleantrash
  • Class / Update
  • Class / Create
  • Class / Delete
  • State / Administrate
  • Role / Assign
  • Role / Update
  • Role / Create
  • Role / Delete
  • Role / Read
  • Section/Edit
  • Section/view
  • Setup / Administrate
  • Setup / Install
  • Setup / Setup
  • Setup / System_info
  • User / Password
  • User / Preferences
  • User / Register
  • User / Selfedit
  • User / Activation
    These two are not in v1, but when you go to edit mode there is nothing to do and it looks bad, so I think it should be also disabled:
  • Url / View
  • Url / Update

barbaragr
barbaragr requested changes Dec 21, 2017
View reviewed changes
Copy link

@barbaragr barbaragr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put an issue in a comment.

@Nattfarinn
Copy link
Contributor Author

@barbaragr Fixed. :)

@Nattfarinn Nattfarinn changed the title EZP-28635: Edit mode for policy .../All functions should be disabled EZP-28635: Make sure policies without limitationTypes are not editable Dec 21, 2017
@lserwatka lserwatka merged commit ebaf7d6 into master Dec 22, 2017
@lserwatka lserwatka deleted the ezp-28635 branch December 22, 2017 08:02
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
@dew326
IBX-2079: Added icons personalize and product catalog (#254)
76bc6f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbaragr barbaragr barbaragr approved these changes

Assignees

@barbaragr barbaragr

Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nattfarinn @barbaragr @lserwatka