Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-28634: Top menu disappear on Search and Trash #250

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Dec 21, 2017

Question Answer
Tickets https://jira.ez.no/browse/EZP-28634
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Top menu disappeared on Search and Trash. Current solution is to show top menu always with selected position "Content" -> "Content structure selected"

screen shot 2017-12-21 at 10 12 47 am

screen shot 2017-12-21 at 10 12 32 am

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mnocon
Copy link
Member

mnocon commented Dec 21, 2017

@mikadamczyk not sure if it's related to this ticket, but this behaviour could not be present before this change:

when you go to "Content -> Media" and then click "Search" the menu switches to "Content -> Content structure). Same applies for "Trash".

Should it be that way?

Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed the above question in private, we can leave it as is for now!

@mikadamczyk
Copy link
Contributor Author

I think this is the best solution for that moment.

@lserwatka lserwatka merged commit 274a910 into ezsystems:master Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants