Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Missing translations for JS validators #249

Merged
merged 1 commit into from
Dec 21, 2017
Merged

fix: Missing translations for JS validators #249

merged 1 commit into from
Dec 21, 2017

Conversation

Nattfarinn
Copy link
Contributor

Question Answer
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@lserwatka lserwatka requested review from dew326 and webhdx December 20, 2017 22:27
@mnocon mnocon self-assigned this Dec 21, 2017
@lserwatka
Copy link
Member

@mnocon what is the status here?

@mnocon
Copy link
Member

mnocon commented Dec 21, 2017

@lserwatka I'm still looking at it

@lserwatka lserwatka merged commit fc4a083 into master Dec 21, 2017
@lserwatka lserwatka deleted the fix-translations branch December 21, 2017 14:02
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
@dew326
IBX-2087: Fixed error in user settings (#249)
6894906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnocon mnocon mnocon approved these changes

@dew326 dew326 Awaiting requested review from dew326

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@mnocon mnocon

Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nattfarinn @lserwatka @mnocon