Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-28611: Add pagination to the Roles list #239

Merged
merged 1 commit into from
Dec 20, 2017
Merged

EZP-28611: Add pagination to the Roles list #239

merged 1 commit into from
Dec 20, 2017

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Dec 19, 2017 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZP-28611
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Added pagination to the Roles list

screen shot 2017-12-19 at 5 22 52 pm

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mikadamczyk mikadamczyk self-assigned this Dec 19, 2017
@mikadamczyk mikadamczyk requested review from webhdx and dew326 December 19, 2017 16:24
@mikadamczyk mikadamczyk changed the title EZP-28609: Add pagination to the Languages list EZP-28609: Add pagination to the Roles list Dec 20, 2017
@m-tyrala m-tyrala self-assigned this Dec 20, 2017
m-tyrala
m-tyrala approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@m-tyrala m-tyrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA tests ok.

@m-tyrala m-tyrala removed their assignment Dec 20, 2017
@mikadamczyk mikadamczyk force-pushed the ezp-28611-add-pagination-to-the-roles-list branch from d47d78c to 39693c1 Compare December 20, 2017 09:22
@m-tyrala m-tyrala self-assigned this Dec 20, 2017
m-tyrala
m-tyrala approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@m-tyrala m-tyrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve after rebase.

@m-tyrala m-tyrala removed their assignment Dec 20, 2017
@mikadamczyk
Copy link
Contributor Author

Thanks @m-tyrala

@lserwatka lserwatka merged commit 8b4145d into ezsystems:master Dec 20, 2017
@mikadamczyk mikadamczyk changed the title EZP-28609: Add pagination to the Roles list EZP-28611: Add pagination to the Roles list Jan 10, 2018
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
@GrabowskiM
IBX-1476: Disable Select All checkbox when all the checkboxes in the …
0d95ff9 
…table row are disabled (#239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webhdx webhdx webhdx approved these changes

@m-tyrala m-tyrala m-tyrala approved these changes

@dew326 dew326 Awaiting requested review from dew326

Assignees

@mikadamczyk mikadamczyk

Labels
QA approved Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikadamczyk @webhdx @m-tyrala @lserwatka