EZP-28463: Updated design for Modal Send to trash #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated based on review. |
sunpietro
suggested changes
Dec 19, 2017
| border-color: $ez-color-base-medium; | ||
|
|
||
| &:hover { | ||
| background-color: darken($ez-color-base-medium, 15%); |
There was a problem hiding this comment.
Shouldn't we use colors defined in _custom.scss? Maybe we should new ones there?
| .ez-content-view, | ||
| .ez-trash-list-view { | ||
| .ez-modal { | ||
| &--send-to-trash { |
There was a problem hiding this comment.
I think one level of nesting might be omitted by setting .ez-modal--send-to-trash
There was a problem hiding this comment.
It can be improved here and there.
| @@ -1,25 +1,26 @@ | |||
| <div class="modal fade" id="delete-section-modal" tabindex="-1" role="dialog"> | |||
| <div class="modal fade ez-modal--send-to-trash" id="delete-section-modal" tabindex="-1" role="dialog"> | |||
There was a problem hiding this comment.
Maybe ez-modal ez-modal--send-to-trash
m-tyrala
suggested changes
Dec 19, 2017
|
ping @sunpietro @m-tyrala |
sunpietro
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most important aspect:
Checklist:
$ composer fix-cs)