Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2000: Added search into URL Wildcard tab #2042

Merged
merged 10 commits into from
May 25, 2022
Merged

IBX-2000: Added search into URL Wildcard tab #2042

merged 10 commits into from
May 25, 2022

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented Apr 22, 2022 •
edited
Loading

Question Answer
Tickets IBX-2000
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes/no
Doc needed? no
License GPL-2.0

related to ezsystems/ezplatform-kernel#301

regression tests passed:
ibexa/commerce#88
ibexa/experience#39

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mateuszdebinski mateuszdebinski marked this pull request as ready for review May 18, 2022 08:02
@mateuszdebinski mateuszdebinski requested review from a team May 18, 2022 08:02
@mateuszdebinski mateuszdebinski self-assigned this May 18, 2022
This was referenced May 20, 2022
Closed
Closed
adamwojs
adamwojs requested changes May 20, 2022
View reviewed changes
@mateuszdebinski mateuszdebinski requested a review from adamwojs May 23, 2022 09:07
@adamwojs
Copy link
Member

Some of the comment are still is not addressed: #2042 (comment)

@mateuszdebinski
Copy link
Contributor Author

Some of the comment are still is not addressed: #2042 (comment)

@adamwojs now should be done

@mateuszdebinski mateuszdebinski requested a review from ViniTou May 24, 2022 13:58
webhdx
webhdx suggested changes May 24, 2022
View reviewed changes
@mateuszdebinski mateuszdebinski requested a review from webhdx May 24, 2022 14:15
@mateuszdebinski mateuszdebinski requested a review from dew326 May 25, 2022 08:19
@mateuszdebinski mateuszdebinski requested a review from dew326 May 25, 2022 08:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tomaszszopinski
tomaszszopinski approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 3.3 commerce.

@Nattfarinn Nattfarinn merged commit d382edf into 2.3 May 25, 2022
@Nattfarinn Nattfarinn deleted the IBX-2000_add_search_to_url_wildcard_tab branch May 25, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@webhdx webhdx webhdx approved these changes

@ViniTou ViniTou ViniTou approved these changes

@OstafinL OstafinL OstafinL approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

@tischsoic tischsoic Awaiting requested review from tischsoic

@dew326 dew326 Awaiting requested review from dew326

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@dew326 dew326

@mateuszdebinski mateuszdebinski

Labels
Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mateuszdebinski @adamwojs @mikadamczyk @Steveb-p @webhdx @dew326 @ViniTou @OstafinL @tomaszszopinski @Nattfarinn