Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] IBX-1193 added log out step in behat #2017

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

tomaszszopinski
Copy link
Contributor

@tomaszszopinski tomaszszopinski commented Nov 26, 2021

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-1193
Bug fix? no
New feature? no (new tests)
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Related PR: https://github.com/ezsystems/ezplatform-workflow/pull/244

This PR adds a simple step for Behat - logging out of the backoffice.

@tomaszszopinski
Copy link
Contributor Author

Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small nitpick

@@ -135,6 +135,14 @@ public function iGoToUserNotifications()
$this->upperMenu->chooseFromUserDropdown('View Notifications');
}

/**
* @Given I log out of backoffice
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like our doc uses "back office": https://doc.ibexa.co/en/latest/extending/extending_back_office/#back-office

Suggested change
* @Given I log out of backoffice
* @Given I log out of back office

/**
* @Given I log out of backoffice
*/
public function iLogOutOfBackoffice()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function iLogOutOfBackoffice()
public function iLogOutOfBackOffice()

@ezsystems ezsystems deleted a comment from sonarqubecloud bot Nov 30, 2021
@tomaszszopinski tomaszszopinski force-pushed the ibx-1193_adding_log_out_to_navigation_context branch from 5add5a7 to 879d67c Compare December 7, 2021 09:36
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micszo micszo merged commit b2f12f9 into 2.3 Dec 7, 2021
@micszo micszo deleted the ibx-1193_adding_log_out_to_navigation_context branch December 7, 2021 10:12
@micszo
Copy link
Member

micszo commented Dec 7, 2021

@tomaszszopinski please merge up/across

@tomaszszopinski tomaszszopinski changed the title [Behat][WiP] IBX-1193 added log out step in behat [Behat]IBX-1193 added log out step in behat Dec 7, 2021
@tomaszszopinski tomaszszopinski changed the title [Behat]IBX-1193 added log out step in behat [Behat] IBX-1193 added log out step in behat Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants