Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-28567: As an editor I want to be able to restore archived Content version #201

Merged
merged 1 commit into from
Dec 18, 2017

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Dec 18, 2017

Question Answer
Tickets https://jira.ez.no/browse/EZP-28567
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@webhdx webhdx self-assigned this Dec 18, 2017
Copy link
Member

@dew326 dew326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nitpicks but in general +1

@@ -52,6 +53,15 @@
</a>
</td>
{% endif %}
{% if is_archived %}
<td>
<button class="btn btn-icon btn--restore-archived-version" data-content-id="{{ version.contentInfo.id }}" data-version-no="{{ version.versionNo }}" data-language-code="{{ version.initialLanguageCode }}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ez-btn--restore-archived-version

(function (global, doc) {
const FORM_ARCHIVED_VERSION_RESTORE = 'form[name="archived_version_restore"]';

const restoreArchivedVersion = event => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(event)

@@ -0,0 +1,25 @@
(function (global, doc) {
const FORM_ARCHIVED_VERSION_RESTORE = 'form[name="archived_version_restore"]';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line

@barbaragr barbaragr self-assigned this Dec 18, 2017
@webhdx
Copy link
Contributor Author

webhdx commented Dec 18, 2017

@dew326 Fixed.

@lserwatka lserwatka merged commit 2d5a48c into ezsystems:master Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants