Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-28338: As an Editor, I want to view specific error page when reaching an http error in Admin #183

Merged
merged 4 commits into from
Dec 15, 2017

Conversation

sunpietro
Copy link
Contributor

Question Answer
Tickets https://jira.ez.no/browse/EZP-28338
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes/no
Doc needed? yes/no
License GPL-2.0

<div class="error-page__image-wrapper">
<img src="{{ asset('bundles/ezplatformadminui/img/errors/403.png') }}" />
</div>
<h2 class="error-page__title">You don’t have permission for this page. Sorry!</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translations?

@m-tyrala m-tyrala self-assigned this Dec 15, 2017
Copy link
Contributor

@m-tyrala m-tyrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA tests ok.

@m-tyrala m-tyrala removed their assignment Dec 15, 2017
@sunpietro
Copy link
Contributor Author

ping @dew326 @m-tyrala

@lserwatka
Copy link
Member

@mikadamczyk will help to generate translations and run cs-fixera here

@m-tyrala m-tyrala self-assigned this Dec 15, 2017
@ezsystems ezsystems deleted a comment from ezrobot Dec 15, 2017
@ezsystems ezsystems deleted a comment from ezrobot Dec 15, 2017
@ezsystems ezsystems deleted a comment from ezrobot Dec 15, 2017
Copy link
Contributor

@m-tyrala m-tyrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA tests ok again.

@m-tyrala m-tyrala removed their assignment Dec 15, 2017
@lserwatka lserwatka merged commit 4e8a95d into master Dec 15, 2017
@Nattfarinn Nattfarinn deleted the error-pages branch March 12, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants