Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-28427: Red label is missing when validation appears #171

Merged
merged 1 commit into from
Dec 14, 2017
Merged

EZP-28427: Red label is missing when validation appears #171

merged 1 commit into from
Dec 14, 2017

Conversation

sunpietro
Copy link
Contributor

Question Answer
Tickets https://jira.ez.no/browse/EZP-28427
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes/no
Doc needed? yes/no
License GPL-2.0

@sunpietro sunpietro self-assigned this Dec 13, 2017
@barbaragr barbaragr self-assigned this Dec 13, 2017
@barbaragr
Copy link

Following latitude and longitude
screen shot 2017-12-13 at 15 23 51

Red font is missing for:

  1. Author: name and e-mail
  2. URL: URL
  3. User: username, password, confirm password, e-mail
    missingfont

barbaragr
barbaragr requested changes Dec 13, 2017
View reviewed changes
Copy link

@barbaragr barbaragr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put an issue in a comment.

@sunpietro sunpietro force-pushed the ezp-28427-validation-incorrect-label-color branch from 1d42154 to ccd36de Compare December 13, 2017 15:23
@sunpietro sunpietro force-pushed the ezp-28427-validation-incorrect-label-color branch from ccd36de to 10a9594 Compare December 13, 2017 17:30
@sunpietro
Copy link
Contributor Author

ping @barbaragr @dew326

barbaragr
barbaragr approved these changes Dec 14, 2017
View reviewed changes
Copy link

@barbaragr barbaragr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

@lserwatka lserwatka merged commit 28995d7 into master Dec 14, 2017
@lserwatka lserwatka deleted the ezp-28427-validation-incorrect-label-color branch December 14, 2017 08:38
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
@dew326 @mnocon
IBX-1812: Added labels in table buttons (#171)
8ec2ed0 
Co-authored-by: Marek Nocoń <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbaragr barbaragr barbaragr approved these changes

@dew326 dew326 dew326 approved these changes

@lserwatka lserwatka Awaiting requested review from lserwatka

Assignees

@sunpietro sunpietro

@barbaragr barbaragr

Labels
Bug QA approved Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunpietro @barbaragr @dew326 @lserwatka