EZP-31029: Adjust Role transformers to introduced type hints in RoleService #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikadamczyk
force-pushed
the
role_service_typehint
branch
from
db00050 to
6ad5478
Compare
10 tasks
mikadamczyk
requested review from
adamwojs,
pawbuj,
ViniTou,
Nattfarinn and
webhdx
adamwojs
approved these changes
Oct 17, 2019
ViniTou
approved these changes
Oct 17, 2019
katarzynazawada
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding type hints to RoleService we must pass
integeras a Role ID to RoleService:: loadRole and RoleService:: loadRoleAssignment methodsNeeds ezsystems/ezpublish-kernel#2822
Checklist:
$ composer fix-cs)