EZP-31417: Added tooltips to UDW #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
force-pushed
the
EZP-31417-added-tooltips
branch
from
9da4564 to
99e1b5d
Compare
GrabowskiM
requested changes
Mar 12, 2020
| useEffect(() => { | ||
| window.eZ.helpers.tooltips.parse(window.document.querySelector('.c-selected-locations')); | ||
| window.eZ.helpers.tooltips.hideAll(); | ||
| window.document.querySelector('.c-selected-locations__toggle-button').dataset.originalTitle = togglerLabel; |
dew326
approved these changes
Mar 13, 2020
GrabowskiM
requested changes
Mar 13, 2020
| @@ -10,6 +10,10 @@ const ContentTable = ({ count, itemsPerPage, items, activePageIndex, title, onPa | |||
| const modifiedLabel = Translator.trans(/*@Desc("Modified")*/ 'content_table.modified', {}, 'universal_discovery_widget'); | |||
| const contentTypeLabel = Translator.trans(/*@Desc("Content Type")*/ 'content_table.content_type', {}, 'universal_discovery_widget'); | |||
|
|
|||
| useEffect(() => { | |||
| window.eZ.helpers.tooltips.parse(window.document.querySelector('.c-content-table')); | |||
GrabowskiM
approved these changes
Mar 13, 2020
|
@lucasOsti please watch the gif and fix the issues |
|
|
|
|
|
Clear input field data button don't have tooltip label
|
lucasOsti
force-pushed
the
EZP-31417-added-tooltips
branch
from
42e7897 to
d61f3a5
Compare
2 tasks
GrabowskiM
requested changes
Mar 23, 2020
| const widgetClassName = createCssClassNames({ | ||
| 'c-content-create': true, | ||
| 'c-content-create--hidden': !createContentVisible, | ||
| }); | ||
|
|
||
| useEffect(() => { | ||
| window.eZ.helpers.tooltips.parse(window.document.querySelector('.c-content-create')); |
There was a problem hiding this comment.
Could it be done with ref instead of querySelector?
| useEffect(() => { | ||
| window.eZ.helpers.tooltips.hideAll(window.document.querySelector('.c-udw-tab')); | ||
|
|
||
| if (refToggleSelectionButton.current.getAttribute('data-original-title')) { |
There was a problem hiding this comment.
I would add some comment here explaining what's happening here
GrabowskiM
approved these changes
Mar 23, 2020
dew326
approved these changes
Mar 24, 2020
bogusez
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tooltips to UDW
Checklist:
$ composer fix-cs)