EZP-30639: Used Content view instead of deprecated Location view #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dew326
previously approved these changes
Feb 5, 2020
ViniTou
approved these changes
Feb 5, 2020
Nattfarinn
force-pushed
the
ezp-30639-deprecate-view-location
branch
from
f86a252 to
860a30b
Compare
dew326
requested changes
Feb 5, 2020
| @@ -28,7 +28,7 @@ const GridViewItemComponent = ({ item, generateLink }) => { | |||
| } | |||
|
|
|||
| return ( | |||
| <a className="c-grid-view-item" href={generateLink(locationId)}> | |||
| <a className="c-grid-view-item" href={generateLink(content._info.id, locationId)}> | |||
There was a problem hiding this comment.
Order of parameters should be changed
GrabowskiM
approved these changes
Feb 6, 2020
dew326
approved these changes
Feb 6, 2020
lucasOsti
approved these changes
Feb 10, 2020
Nattfarinn
force-pushed
the
ezp-30639-deprecate-view-location
branch
from
23aab67 to
24a6aeb
Compare
Nattfarinn
force-pushed
the
ezp-30639-deprecate-view-location
branch
from
e63125b to
2a5956a
Compare
Nattfarinn
force-pushed
the
ezp-30639-deprecate-view-location
branch
from
2a5956a to
627dcc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-30639
Depends on: ezsystems/ezplatform-admin-ui#1225