EZP-27271: Unable to upload large binary file using REST / Platform UI

[kmadejski]

JIRA issue: https://jira.ez.no/browse/EZP-27271

Description

Currently, this PR contains only the first step related to the backend: try to DRY and reuse once parsed and created RestContentCreateStruct object.

Related changes

The related changes in the kernel are here ezsystems/ezpublish-kernel#2268

[adamwojs]

Let's do this in another way:

On the kernel side: from the \eZ\Publish\Core\REST\Server\Controller\Content::createContent method let's extract:

try {
    $content = $this->repository->getContentService()->createContent(
        $contentCreate->contentCreateStruct,
        array($contentCreate->locationCreateStruct)
    );
} catch (ContentValidationException $e) {
    throw new BadRequestException($e->getMessage());
} catch (ContentFieldValidationException $e) {
    throw new RESTContentFieldValidationException($e);
}

$contentValue = null;
$contentType = null;
$relations = null;
if ($this->getMediaType($request) === 'application/vnd.ez.api.content') {
    $contentValue = $content;
    $contentType = $this->repository->getContentTypeService()->loadContentType(
        $content->getVersionInfo()->getContentInfo()->contentTypeId
    );
    $relations = $this->repository->getContentService()->loadRelations($contentValue->getVersionInfo());
}

return new Values\CreatedContent(
    array(
        'content' => new Values\RestContent(
            $content->contentInfo,
            null,
            $contentValue,
            $contentType,
            $relations
        ),
    )
);

to the new protected method \eZ\Publish\Core\REST\Server\Controller\Content::doCreateContent(ContentCreate $contentCreate) (name could be better).

On the PlatformUI let's change \EzSystems\PlatformUIBundle\Controller\Rest\ContentController::createContent in this way:

public function createContent(Request $request)
{
   $contentCreate = $this->inputDispatcher->parse(
        new Message(
            array('Content-Type' => $request->headers->get('Content-Type')),
            $request->getContent()
        )
    );

    if (!$this->isUserCreateRequest($request, $contentCreate)) {
        return parent::doCreateContent($contentCreate);
    }

    $createdUser = $this->repository->getUserService()->createUser(
        $this->mapRequestToUserCreateStruct($request),
        $this->mapRequestToParentGroups($request)
    );

    return $this->mapUserToCreatedContent($createdUser);
}

[kmadejski]

ping @adamwojs, I've applied the changes which you've proposed, thanks!

[kmadejski]

@andrerom PR changed as requested in ezsystems/ezpublish-kernel#2268 (comment) 🙂

ping @adamwojs, @andrerom do the review once again, please.

Update: adapted accordingly to the changes in kernel.

[kmadejski]

All tests passed for a4c9c64 (https://travis-ci.org/ezsystems/PlatformUIBundle/builds/354367290). These ones will probably fail due to changed kernel requirements. Besides that, I think that this PR is ready for merge. @andrerom could you review, please?

[andrerom]

you can set it to ~6.7.8@dev || ^6.13.2@dev, we'll ideally have to cleanup after release, but otherwise this will break travis on merge